Naser Mahfouz

Results 45 issues of Naser Mahfouz

We currently special-case this to be true for ERS/ERP tests, but we really oughta make it true by default

EAMxx

See https://github.com/E3SM-Project/E3SM/issues/7326 for context as an example of the issue.

Diagnostics being their own derived classes are supposed to handle variety of inputs/outputs. - Sometimes diagnostics can produce their own fillval depending on conditions. Take FieldAtXyz being unavailable on a...

help wanted
EAMxx

The idea of our diagnostics is that we can query them inside each other, and we can do composable and fancy stuff online. It took me a while to realize...

EAMxx

as title, will have a PR ready soon

run_e3sm
EAMxx
code usability

Currently, we only rigorously test diagnostics in their isolated standalone testing; we should add a testmod that will cover the following: 1. a representative set of all possible diagnostics outputs...

help wanted
EAMxx

No reason to keep COSP as AtmosProc. We should make it an as-you-need AtmosDiag instead.

help wanted
EAMxx
COSP

In some places in EAMxx, we bare-include a file that will presumably be generated at compile time. An example is eamxx_config.h.in (in components/eamxx/src) --> eamxx_config.h (in the bld folder eventually)....

help wanted
CMake build system
EAMxx
code usability

we often break @bogensch's workflow because we are not testing it correctly, and @bogensch and @jsbamboo often alert us in issues. This is no good, we are wasting their time....

EAMxx

Is this just to make it so that the output nc files have different names for each instance? Perhaps we should handle this from inside our IO layer. We should...

help wanted
EAMxx