magritte icon indicating copy to clipboard operation
magritte copied to clipboard

#reference auto-generation seems to be corrupted [incomplete issue, in progress]

Open Assargadon opened this issue 1 year ago • 1 comments

That's how MARelationDescription >> reference is implemented:

MARelationDescription >> reference [
	"The reference within a ==*MARelationDescription*== is calculated automatically from all the classes of the receiver, if set to ==nil==. By setting the reference to a ==*MAContainer*== instance it is possible to customize the reference description."

	^ super reference ifNil: [ self commonClass magritteTemplate magritteDescription ]
]

The trouble is that super reference is never nil, because it has its own ifNil generator:

MAReferenceDescription >> reference [
	reference ifNil: [ reference := self class defaultReference ].
	^ reference
		display: self displayBlockOrSymbol;
		yourself
]

Therefore, commonClass-based generator is actually never called.

This ticket is in progress. Things to describe: unintuitive defaultReferences and mistake (well, I assume it's a mistake) in managing the commonClass if there are no classes. A latter, I believe, forced the author to add extra unneeded magritteTemplate into...MAContainer, I believe, but need to re-check.

Assargadon avatar Sep 08 '23 15:09 Assargadon

To limit bug bankruptcy (see https://www.joelonsoftware.com/2012/07/09/software-inventory/) this issue has been automatically marked as stale because it has not had any activity in 6 months. If no further activity occurs, it might be closed. If this issue remains important to you, please comment to reactivate the issue. Thank you for your contributions.

stale[bot] avatar Dec 15 '23 06:12 stale[bot]