magpie
magpie copied to clipboard
Add BE price incentive realization for 1st and 2nd gen
:bird: Description of this PR :bird:
This PR prepares MAgPIE for its use in the MAgPIE-MESSAGE emulator. Primarily, this includes a new realization that is a slight variation of the current default for 60_bioenergy, allowing for price-driven BE production. It also includes several other smaller changes such as, optional, an early afforestation block and a cropland growth constraint.
:wrench: Checklist for PR creator :wrench:
-
[x] Label pull request from the label list.
- Low risk: Simple bugfixes (missing files, updated documentation, typos) or changes in start or output scripts
- Medium risk: Uncritical changes in the model core (e.g. moderate modifications in non-default realizations)
- High risk: Critical changes in model core or default settings (e.g. changing a model default or adjusting a core mechanic in the model)
-
[x] Self-review own code
- No hard coded numbers and cluster/country/region names.
- The new code doesn't contain declared but unused parameters or variables.
-
magpie4
R library has been updated accordingly and backwards compatible where necessary. -
scenario_config.csv
has been updated accordingly (important ifdefault.cfg
has been updated)
-
[x] Document changes
- Add changes to
CHANGELOG.md
- Where relevant, put In-code documentation comments
- Properly address updates in interfaces in the module documentations
- run
goxygen::goxygen()
and verify the modified code is properly documented
- Add changes to
-
[x] Perform test runs
-
Low risk:
- Run a compilation check via
Rscript start.R --> "compilation check"
- Run a compilation check via
-
Medium risk:
- Run test runs via
Rscript start.R --> "test runs"
- Check logs for errors/warnings
- Run test runs via
-
High risk:
- Run test runs via
Rscript start.R --> "test runs"
- Check logs for errors/warnings
- Default run from the PR target branch for comparison
- Provide relevant comparison plots (land-use, emissions, food prices, land-use intensity,...)
- Run test runs via
-
Low risk:
:chart_with_downwards_trend: Performance changes :chart_with_upwards_trend:
- Current develop branch default : 20 mins
- This PR's default : 23 mins
:rotating_light: Checklist for reviewer :rotating_light:
- PR is labeled correctly
- Code changes look reasonable
- No hard coded numbers and cluster/country/region names.
- No unnecessary increase in module interfaces
- model behavior/performance is satisfactory.
- Changes are properly documented
-
CHANGELOG
is updated correctly - Updates in interfaces have been properly addressed in the module documentations
- In-code documentation looks appropriate
-
- [ ] content review done (at least 1)
- [x] RSE review done (at least 1)