node-libquassel icon indicating copy to clipboard operation
node-libquassel copied to clipboard

libquassel won't connect to quassel core that only supports TLS 1.3

Open thinkl33t opened this issue 4 years ago • 1 comments

I've spent some time digging into why my quassel-webserver will no longer connect to my quassel core. According to quassel and quasseldroid, my core uses TLS 1.3, but I have found the following:

https://github.com/magne4000/node-libquassel/blob/0cf97378ebe170b0abf4bdcc112933009a84156f/src/request.js#L160

Which appears to set libquassel to only use TLS 1.2.

According to the node TLS documentation, this is now deprecated, and we should be using minversion when creating an SSL context.

Suggest changing this line to:

        minVersion: 'TLSv1.2'

Though i may be barking entirely up the wrong tree here, as i'm not a node developer. It looks like someone else tried this previously in quassel-webserver: https://github.com/magne4000/quassel-webserver/issues/285

thinkl33t avatar Dec 07 '21 16:12 thinkl33t

That's not actually webquassel (the node process) that initiates TLS connection to the server, but directly the browser thanks to forge. So to support TLS1.3 this repo either need an updated version of forge that supports TLS1.3 (still no implemented), or find another method or lib. Sadly is not an easy thing to do if it's even possible, and I'm not actively keeping this repo updated, so for now it's not on the list of things that will be implemented by me (PR or suggestions welcome though)

magne4000 avatar Dec 07 '21 17:12 magne4000