fix(agw): fix always-true-asserts in s1ap integ tests

[wolfseb]

Signed-off-by: Sebastian Wolf [email protected]

Summary

After #14012 , some asserts were using an incorrect syntax that always yields true: assert(condition, "description"). This PR changes these to function as intended: assert condition, "description"

Example warning:

Affected tests:

• test_agw_offload_idle_active_ue
• test_attach_detach_multiple_rar_tcp_data
• test_attach_detach_rar_tcp_data
• test_attach_detach_rar_tcp_he
• test_attach_detach_setsessionrules_tcp_data
• test_attach_detach_with_ovs

Test Plan

Run the affected tests and see that the warnings disappear.

Additional Information

• [ ] This change is backwards-breaking

[github-actions[bot]]

Thanks for opening a PR! :100:

A couple initial guidelines

• All commits must be signed off. This is enforced by DCO check.
• All PR titles must follow the semantic commits format. This is enforced by Semantic PR.

Howto

• Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
• Checks. All required CI checks must pass before merge.
• Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

• Contributing Conventions for norms around contributed code

If this is your first Magma PR, also consider reading

• Developer Onboarding for onboarding as a new Magma developer
• Development Workflow for guidance on your first pull request
• CI Checks for points of contact for failing or flaky CI checks
• GitHub-to-Slack mappings for Magma maintainers for guidance on how to contact maintainers on Slack

[github-actions[bot]]

Oops! Looks like you failed the Python Format Check.

Howto

• Instructions on running the formatter and linter locally are provided in the format AGW doc
• Guide to the different CI checks and resolution guidelines

:recycle: Updated: :white_check_mark: The check is passing the Python Format Check after the last commit.

[github-actions[bot]]

feg-workflow

    2 files  203 suites   40s :stopwatch: 374 tests 374 :heavy_check_mark: 0 :zzz: 0 :x: 388 runs  388 :heavy_check_mark: 0 :zzz: 0 :x:

Results for commit 2d4f89ab.

:recycle: This comment has been updated with latest results.

[github-actions[bot]]

dp-workflow

14 tests   14 :heavy_check_mark:  2m 11s :stopwatch:   1 suites    0 :zzz:   1 files      0 :x:

Results for commit 2d4f89ab.

:recycle: This comment has been updated with latest results.

[github-actions[bot]]

agw-workflow

615 tests   611 :heavy_check_mark:  5m 22s :stopwatch:     2 suites      4 :zzz:     2 files        0 :x:

Results for commit 2d4f89ab.

:recycle: This comment has been updated with latest results.