magma
magma copied to clipboard
chore(ci): Run the LTE integ_tests with Bazel
Signed-off-by: Krisztián Varga [email protected] Co-authored-by: Lars Kreutzer [email protected] Co-authored-by: Krisztián Varga [email protected]
Summary
In the LTE integ test Bazel workflow the integration tests are now run with Bazel. This closes #13381
Test Plan
For testing see: https://github.com/magma/magma/issues/13381
Final config run (With some unrelated test failures, which happen at master too.):
- https://github.com/vktng/magma/runs/7997130758?check_suite_focus=true
- https://github.com/LKreutzer/magma/runs/8010104491?check_suite_focus=true
- https://github.com/vktng/magma/runs/8067865104?check_suite_focus=true
Run without sudo tests:
- https://github.com/vktng/magma/runs/8067945830?check_suite_focus=true
Runs with good list: with sudo tests:
- https://github.com/vktng/magma/runs/8074534983?check_suite_focus=true
- 2h 3m with 1 failing test
- Bazel
- https://github.com/vktng/magma/runs/8089413333?check_suite_focus=true
- Bazel
- flaky test removed
- publishing results
- https://github.com/vktng/magma/runs/8074530090?check_suite_focus=true
- Make
Without sudo tests:
- https://github.com/vktng/magma/runs/8074913942?check_suite_focus=true
New runs after rebase:
- https://github.com/vktng/magma/runs/8110989651?check_suite_focus=true
- https://github.com/vktng/magma/runs/8130071536?check_suite_focus=true
- with disable checksumming
Run with fix from https://github.com/magma/magma/pull/13803: https://github.com/LKreutzer/magma/runs/8152381609?check_suite_focus=true
Additional Information
- [ ] This change is backwards-breaking
Thanks for opening a PR! :100:
- All commits must be signed off. This is enforced by
DCO check
. - All PR titles must follow the semantic commits format. This is enforced by
Semantic PR
.
Howto
- Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
- Checks. All required CI checks must pass before merge.
-
Merge. Once approved and passing CI checks, use the
ready2merge
label to indicate the maintainers can merge your PR.
More info
Please take a moment to read through the Magma project's
- Contributing Conventions for norms around contributed code
If this is your first Magma PR, also consider reading
- Developer Onboarding for onboarding as a new Magma developer
- Development Workflow for guidance on your first pull request
- CI Checks for points of contact for failing or flaky CI checks
- GitHub-to-Slack mappings for Magma maintainers for guidance on how to contact maintainers on Slack
feg-workflow
2 files 203 suites 39s :stopwatch: 374 tests 374 :heavy_check_mark: 0 :zzz: 0 :x: 388 runs 388 :heavy_check_mark: 0 :zzz: 0 :x:
Results for commit 45ffc1da.
:recycle: This comment has been updated with latest results.
dp-workflow
14 tests 14 :heavy_check_mark: 2m 10s :stopwatch: 1 suites 0 :zzz: 1 files 0 :x:
Results for commit 45ffc1da.
:recycle: This comment has been updated with latest results.
agw-workflow
615 tests 611 :heavy_check_mark: 3m 47s :stopwatch: 2 suites 4 :zzz: 2 files 0 :x:
Results for commit 45ffc1da.
:recycle: This comment has been updated with latest results.
Oops! Looks like you failed the Python Format Check
.
Howto
- Instructions on running the formatter and linter locally are provided in the format AGW doc
- Guide to the different CI checks and resolution guidelines
:recycle: Updated: :white_check_mark: The check is passing the Python Format Check after the last commit.
Oops! Looks like you failed the DCO check
. Be sure to sign all your commits.
Howto
- Magma guidelines on signing commits
-
About the
signoff
feature - Howto: sign-off most-recent commit
- Howto: sign-off multiple past commits
- Guide to the different CI checks and resolution guidelines
:recycle: Updated: :white_check_mark: The check is passing the DCO check after the last commit.
from offline discussion: runtime on forks seems to be long - is the reason that tests are failing (i.e., timeouts etc)? This should be analyzed.
Rebased on fabfile and workflow changes
Tests will not be executed with bazel. This has performance issues:
- hypothesis is that the large pythonpath generated by bazel is causing this.
- integ tests do not benefit from bazel caching as they need to be executed every time - and a relatively small artifacts with a long run-time
- see also https://github.com/bazelbuild/rules_python/issues 311
Bute the environment for test execution will be build with bazel - see #14286.