magma icon indicating copy to clipboard operation
magma copied to clipboard

docs(agw): Added Docker AGW install docs

Open ShubhamTatvamasi opened this issue 2 years ago • 3 comments

Signed-off-by: Shubham Tatvamasi [email protected]

Summary

Test Plan

Additional Information

  • [ ] This change is backwards-breaking

ShubhamTatvamasi avatar Aug 13 '22 21:08 ShubhamTatvamasi

Thanks for opening a PR! :100:

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

github-actions[bot] avatar Aug 13 '22 21:08 github-actions[bot]

dp-workflow

0 tests   0 :heavy_check_mark:  0s :stopwatch: 0 suites  0 :zzz: 0 files    0 :x:

Results for commit 6b903601.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Aug 13 '22 21:08 github-actions[bot]

Oops! Looks like you failed the Markdown lint check.

Howto

:recycle: Updated: :white_check_mark: The check is passing the Markdown lint check after the last commit.

github-actions[bot] avatar Aug 13 '22 21:08 github-actions[bot]

In Prerequisites section: Mention as aarch64 or 64 bit-X86

Regarding the registry location - Can the user use the location below to test 1.8 AGW images ? I am not able to use it in my test environment. Can you add the docker registry details for test environment as "docker-test.artifactory.magmacore.org/" ? DOCKER_REGISTRY=,DOCKER_REGISTRY=docker.artifactory.magmacore.org

At the time of releasing this document, the docker images will be available. I don't think we should update this in docs.

ShubhamTatvamasi avatar Aug 17 '22 08:08 ShubhamTatvamasi

Looks good to me.

m-govind avatar Aug 17 '22 12:08 m-govind