magma
magma copied to clipboard
magma
fix(mme): Add libsqlite3 dependency in containers for OAI pipeline
Signed-off-by: Shruti Sanadhya [email protected]
Summary
The changes in PR https://github.com/magma/magma/pull/13470 require libsqlite to be present on all dev containers. This PR adds the changes in https://github.com/magma/magma/pull/13470#issuecomment-1209363734 to make it work on Magma-OAI-Jenkins CI pipeline.
Test Plan
N/A
Thanks for opening a PR! :100:
- All commits must be signed off. This is enforced by
DCO check. - All PR titles must follow the semantic commits format. This is enforced by
Semantic PR.
Howto
- Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
- Checks. All required CI checks must pass before merge.
-
Merge. Once approved and passing CI checks, use the
ready2mergelabel to indicate the maintainers can merge your PR.
More info
Please take a moment to read through the Magma project's
- Contributing Conventions for norms around contributed code
If this is your first Magma PR, also consider reading
- Developer Onboarding for onboarding as a new Magma developer
- Development Workflow for guidance on your first pull request
- CI Checks for points of contact for failing or flaky CI checks
- GitHub-to-Slack mappings for Magma maintainers for guidance on how to contact maintainers on Slack
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
feg-workflow
2 files 203 suites 40s :stopwatch: 374 tests 374 :heavy_check_mark: 0 :zzz: 0 :x: 388 runs 388 :heavy_check_mark: 0 :zzz: 0 :x:
Results for commit eca8618c.
:recycle: This comment has been updated with latest results.
dp-workflow
13 tests 13 :heavy_check_mark: 2m 3s :stopwatch: 1 suites 0 :zzz: 1 files 0 :x:
Results for commit eca8618c.
:recycle: This comment has been updated with latest results.
agw-workflow
615 tests 611 :heavy_check_mark: 3m 44s :stopwatch: 2 suites 4 :zzz: 2 files 0 :x:
Results for commit eca8618c.
:recycle: This comment has been updated with latest results.
@rdefosse , can you help me understand why this PR is failing on Magma-OAI-Jenkins pipeline? The logs only show warnings, no errors.
@rdefosse , can you help me understand why this PR is failing on Magma-OAI-Jenkins pipeline? The logs only show warnings, no errors.
for me apt list libsqlite3x has no candidates on ubuntu 20.04
Maybe it should be this package in Ubuntu Focal? https://packages.ubuntu.com/focal/libsqlite3-0
Thanks for the review @rdefosse ! I have revised the PR and all required CI checks are green now. Could you please approve and merge this?