d3-graphviz icon indicating copy to clipboard operation
d3-graphviz copied to clipboard

Upgrade to d3 version 7 and adopt type=module

Open magjac opened this issue 2 years ago • 1 comments

magjac avatar Sep 08 '22 09:09 magjac

Codecov Report

Merging #242 (e7509e6) into master (3630ed9) will not change coverage. The diff coverage is 100.00%.

:exclamation: Current head e7509e6 differs from pull request most recent head ab08920. Consider uploading reports for the commit ab08920 to get more accurate results

@@             Coverage Diff             @@
##            master      #242     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files           37        39      +2     
  Lines         1114      2282   +1168     
===========================================
+ Hits          1114      2282   +1168     
Impacted Files Coverage Δ
index.js 100.00% <100.00%> (ø)
src/dot.js 100.00% <100.00%> (ø)
src/drawEdge.js 100.00% <100.00%> (ø)
src/drawNode.js 100.00% <100.00%> (ø)
src/graphviz.js 100.00% <100.00%> (ø)
src/render.js 100.00% <100.00%> (ø)
src/selection/graphviz.js 100.00% <100.00%> (ø)
src/selection/index.js 100.00% <100.00%> (ø)
src/svg.js 100.00% <100.00%> (ø)
src/workerCode.js 100.00% <100.00%> (ø)
... and 38 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Sep 08 '22 09:09 codecov[bot]

@magjac are you planning to merge and release this soon(ish)?

Thanks!

mcmartins avatar Nov 01 '22 11:11 mcmartins

Yes, but I have a few test cases that do not pass yet which I need to figure out how to fix first. Hopefully I can carve out some time for this during this week.

magjac avatar Nov 01 '22 20:11 magjac

Right now I'm on a detour in the https://github.com/magjac/d3-graphviz/tree/DEBUG-upgrade-to-d3-version-7 branch.

magjac avatar Nov 01 '22 20:11 magjac

Awesome @magjac !

mcmartins avatar Dec 28 '22 14:12 mcmartins