MagiumMagento icon indicating copy to clipboard operation
MagiumMagento copied to clipboard

phpunit requirement breaks on Magento 2.2

Open nesh-younify opened this issue 6 years ago • 6 comments

https://github.com/magium/MagiumMagento/blob/5833cb700b6c301c602b98bb0c474b395176932c/composer.json#L21

M2.2 (released yesterday) now uses "phpunit/phpunit": "~6.2.0", so composer refuses to install magium/magento due to version conflict. Also seen in https://github.com/magium/Magium/blob/3e7f1d91968ec52b91dba2ffb7e62172ead36819/composer.json#L20

Not sure if it's safe to update phpunit versions on both of them to 6.* so I did not made forks and pull requests (yet).

nesh-younify avatar Sep 27 '17 13:09 nesh-younify

Sorry for the delay and thank you for bringing it to my attention. I don't currently have it on a schedule to address but I will keep the issue open until I'm done with it. However, if you want to take a stab at it feel free to make a PR.

kschroeder avatar Sep 27 '17 23:09 kschroeder

I tried upgrading the phpunit version, but now it breaks on symfony/console, as Magento2 requires <= 2.7 and magium/magium requires version 3. :/

JKetelaar avatar Nov 07 '17 15:11 JKetelaar

@JKetelaar I have updated magium/magium to 1.1.14 which will use either symfony/console 2 or 3. All the tests passed and I was able to install magium/magium, magium/magento and magium/magento2 on Magento 2.2.1

kschroeder avatar Nov 09 '17 15:11 kschroeder

You, hero!

JKetelaar avatar Nov 09 '17 15:11 JKetelaar

@nesh-younify I've looked into your issue more and it looks like there are some interface incompatibilities that I will need to take into account for the phpunit version. So, it's still on my radar but it won't be a quick fix.

kschroeder avatar Nov 09 '17 15:11 kschroeder

@nesh-younify Could you try running it with {"magium/magium": "dev-master#e3b4fbabeac84d00b0dff3c3a38b5ec91e7d3bef"}? I've added a compatibility layer (one that I'm not so proud of, but it seems to work) to allow for either PHPUnit 5 or 6.

kschroeder avatar Nov 21 '17 18:11 kschroeder