forge icon indicating copy to clipboard operation
forge copied to clipboard

Show more reviews (and similar "events"), alongside topic posts

Open mogorman opened this issue 5 years ago • 5 comments

We use the github feature for marking a pr reviewed. the posts it generates in the topic don't seem to show up for me. Other posts entered on the pr do seem to show up so not sure where the problem might be.

mogorman avatar Jan 03 '19 15:01 mogorman

Github doesn't treat these events as "posts". But this information is useful and eventually Forge will fetch and display it.

tarsius avatar Jan 03 '19 16:01 tarsius

Design-wise, would you consider them posts, a post subclass, or a different type entirely?

vermiculus avatar Jan 03 '19 17:01 vermiculus

cool @tarsius changed topic. thanks for info. magit is amazing as im sure you already know.

mogorman avatar Jan 03 '19 17:01 mogorman

I don't know yet.

We could also treat posts as a subtype of a new event type. That's what Gitlab does.

So with Gitlab we get those non-post events for free (especially after b019dfa6c9d3ff084b209837fce638bf4f117d5b), but there are other problems. As mentioned in that commit, events have no "subtype" field (at least I didn't see something like that when I last checked). And Gitlab additionally supports "threads" which are secondary discussions attached to a topic that are separate from the "normal posts" and "non-post events". I haven't looked into this any further, but it looked messy at first sight.

tarsius avatar Jan 03 '19 19:01 tarsius

Github CI integration result is another type of information about a topic that could usefully be displayed in forge.

thomas-riccardi avatar Jan 07 '19 18:01 thomas-riccardi