magicui icon indicating copy to clipboard operation
magicui copied to clipboard

feat: Add 'borderWidth' prop to Border Beam

Open Rishit30G opened this issue 7 months ago • 4 comments

https://github.com/user-attachments/assets/9cfe906e-8af1-42fe-b6a2-c57c76369b3e

Rishit30G avatar May 24 '25 03:05 Rishit30G

@Rishit30G is attempting to deploy a commit to the product-studio Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar May 24 '25 03:05 vercel[bot]

This is a good one if you can update it in the tailwind itself instead of using style.

itsarghyadas avatar May 25 '25 19:05 itsarghyadas

Thanks for the review @itsarghyadas! I don't think Tailwind can handle dynamic values at run time, so it's best to use styles here

Rishit30G avatar May 26 '25 03:05 Rishit30G

Any thoughts @itsarghyadas ?

Rishit30G avatar May 28 '25 03:05 Rishit30G

@itsarghyadas, please acknowledge 🙇🏻

Rishit30G avatar Jun 01 '25 10:06 Rishit30G

Sorry for the delay, @Rishit30G

Your approach looks good! However, we prefer to keep everything within Tailwind classes where possible.

Yes, you can pass props as CSSProperties, I’ve updated the PR to use Tailwind’s arbitrary value syntax instead.

Thanks for your contribution!

itsarghyadas avatar Jun 27 '25 08:06 itsarghyadas

Thanks @itsarghyadas, appreciate the efforts! 🚀

Rishit30G avatar Jun 27 '25 08:06 Rishit30G