KCT icon indicating copy to clipboard operation
KCT copied to clipboard

Published 20 hours ago • verified publisher icon magico13

Fill Tanks support for Procedural Parts

Open magico13 opened this issue 10 years ago • 4 comments

See here.

For procedural parts we should probably just figure out what the maximum fuel level is and just fill it up to that rather than checking the part prefab.

magico13 avatar Aug 22 '15 14:08 magico13

Looking forward to this!

enceos avatar Aug 23 '15 08:08 enceos

Good, I'll be glad to test this out!

enceos avatar Aug 26 '15 15:08 enceos

Let me know if you encounter any issues with it. I didn't get a chance to test it out last night, unfortunately.

magico13 avatar Aug 26 '15 15:08 magico13

I got time to test the fix only today and understood why this issue was reopened :) I'm getting this NRE spam in the VAB while editing my recovered SSTO:

NullReferenceException: Object reference not set to an instance of an object
  at Part.requestResource (.Part origin, Int32 resourceID, ResourceFlowMode flowMode, Double demand, Int32 requestID) [0x00000] in <filename unknown>:0 
  at Part.RequestResource (Int32 resourceID, Double demand) [0x00000] in <filename unknown>:0 
  at ModuleGenerator.FixedUpdate () [0x00000] in <filename unknown>:0

While the Fill Tanks button doesn't fill tanks with switchers, I still could refill all tanks manually without any construction time penalty.

enceos avatar Sep 07 '15 14:09 enceos