KCT icon indicating copy to clipboard operation
KCT copied to clipboard

KerbalKonstructs for KSP 1.4 will break KTC integration.

Open GER-Space opened this issue 6 years ago • 2 comments

Hi magico13,

I have to make a sad announcement, but for compatibility with KSP1.4 I will have to rename the LaunchSite Class into KKLaunchSite, becasue KSP now has its own class. But: You are only intrested in open LaunchSites and maybe you can get them through KSP directly, as soon I found a way to feed them into KSP without the expansion installed.

Do you want an PR with the changes, or will you make it by yourself?

GER-Space avatar Mar 09 '18 07:03 GER-Space

I can just do it myself unless you already have a PR ready. And you shouldn't have to rename anything since they're in different namespaces, but you'd have to fully qualify any uses of LaunchSite to remove any ambiguity.

magico13 avatar Mar 09 '18 15:03 magico13

With 1.4 you can get all Launchsites from (Stock ones, all DLC and hopefully KK with)

PsystemSetup.instance.LaunchSites

No need to use reflection to Kerbal Konstructs. I need to fill this list with all open launchsites, so I can launch vessel again. This all changed.

The open LS are that what you care about, right? Using fully qualified named in my own code is a NoGo for me. Its ugly to read

GER-Space avatar Mar 09 '18 15:03 GER-Space