bash-git-prompt icon indicating copy to clipboard operation
bash-git-prompt copied to clipboard

Solarized_UserHost showing up as 'root@localhost #️ {ResetColor}' and keeping red color

Open kisp opened this issue 2 years ago • 3 comments

When I ssh into my Arch Linux box the prompt is shown as

✔ ~
root@localhost #️ {ResetColor}

and the color for typing commands is red.

Can you help me tracking down why this happens? :)

kisp avatar Apr 05 '23 05:04 kisp

cc @rkitover @guenhter

I did a git bisect and https://github.com/magicmonty/bash-git-prompt/commit/0eb0947955ccf2855dcef88ad48aaef1fbb5c188 was identified as the problematic commit.

Indeed, when I run git revert 0eb0947955ccf2855dcef88ad48aaef1fbb5c188, the problem goes away and my prompt is shown as

✔  ~
root@localhost  #️

Strangely, when I log into my local machine via ssh the prompt works (without having to revert).

Any ideas? :)

kisp avatar Apr 05 '23 05:04 kisp

Oh, I see... I think the GIT_PROMPT_END_ROOT version misses a $.

#️ {ResetColor} should be #️${ResetColor}

Do you want me to provide a PR? :)

diff --git a/themes/Solarized_UserHost.bgptheme b/themes/Solarized_UserHost.bgptheme
index aa3638a..0f18940 100644
--- a/themes/Solarized_UserHost.bgptheme
+++ b/themes/Solarized_UserHost.bgptheme
@@ -15,7 +15,7 @@ function override_git_prompt_colors() {
   GIT_PROMPT_START_USER="_LAST_COMMAND_INDICATOR_${Yellow}${PathShort}"
   GIT_PROMPT_START_ROOT="${GIT_PROMPT_START_USER}"
   GIT_PROMPT_END_USER="\n${BoldBlue}\\u${bold_bright_white}@${BoldBlue}\\h${BoldRed} ➤${ResetColor} "
-  GIT_PROMPT_END_ROOT="\n${BoldBlue}\\u${bold_bright_white}@${BoldBlue}\\h${BoldRed} #️ {ResetColor} "
+  GIT_PROMPT_END_ROOT="\n${BoldBlue}\\u${bold_bright_white}@${BoldBlue}\\h${BoldRed} #️${ResetColor} "
   GIT_PROMPT_LEADING_SPACE=1
   GIT_PROMPT_PREFIX="${Cyan}["
   GIT_PROMPT_SUFFIX="${Cyan}]"

kisp avatar Apr 05 '23 05:04 kisp

Hi @kisp, sorry about that.

By the way, I am working on my own prompt, which is similar to this theme:

https://github.com/rkitover/sh-prompt-simple

rkitover avatar Apr 09 '23 16:04 rkitover