go-streamdeck icon indicating copy to clipboard operation
go-streamdeck copied to clipboard

[BUG] Border decorator only works for the XL

Open magicmonkey opened this issue 5 years ago • 4 comments

Describe the bug There's a hard-coded "96" in the border decorator code

Streamdeck version Anything except an XL

Additional context This needs to look at the dimensions of the incoming image, rather than looking up what streamdeck is in use.

magicmonkey avatar Jun 14 '20 17:06 magicmonkey

There's a couple of other places as well, check for TODO comments or a hard-coded "96"

magicmonkey avatar Jun 14 '20 19:06 magicmonkey

I've just (slightly) modified streamdeck-tricks, and the border works "just fine" on my 5x3 stream deck.

derickr avatar Sep 04 '20 16:09 derickr

Ah that's a good datapoint, thanks @derickr

magicmonkey avatar Sep 05 '20 11:09 magicmonkey

On 5 September 2020 12:41:44 BST, Kevin Bowman [email protected] wrote:

Ah that's a good datapoint, thanks @derickr

Btw, if you have a list of things to test with the 5*3 Classic, I'm happy to check.

derickr avatar Sep 05 '20 12:09 derickr