magic-js icon indicating copy to clipboard operation
magic-js copied to clipboard

Bug Report: Endless Cookie Rendering Loop

Open Adebesin-Cell opened this issue 11 months ago • 5 comments

✅ Prerequisites

  • [x] Did you perform a cursory search of open issues? Is this bug already reported elsewhere?
  • [x] Are you reporting to the correct repository (magic-sdk)?

🐛 Description

Upon initializing the Wagmi connector into my project, I noticed a peculiar behavior related to cookie rendering.

🧩 Steps to Reproduce

  1. Integrate the Wagmi connector into the project.
  2. Initialize the Wagmi connector within the codebase.
  3. Observe the rendering behavior of cookies.
  4. Notice the continuous rendering of cookies without halt.

🤔 Expected behavior

I expected the cookies to render appropriately upon initialization and to cease rendering once initialized. There should be no continuous loop of cookie rendering.

😮 Actual behavior

The cookies enter an infinite rendering loop, continually rendering without cessation. This behavior triggers an error marked with number of times it has rendered, indicating that the cookies have been rendered an excessive number of times. Consequently, this error warns that third-party cookie functionality may be blocked.

💻 Code Sample

https://stackblitz.com/edit/stackblitz-starters-bbb65e?file=app%2Fpage.tsx,app%2Fconfig.ts,package.json

Screenshots

Screenshot 2024-03-25 at 5 38 25 PM

🌎 Environment

Software Version(s)
magic-sdk 18.3.0
Browser Vivaldi
yarn >=1.22.0
Operating System Mac OS Ventura 13.1 (22C65)

Adebesin-Cell avatar Mar 25 '24 16:03 Adebesin-Cell

This seems to be a issue on almost all sites that has magic login integrations

image

image image image

Royal-lobster avatar Mar 27 '24 04:03 Royal-lobster

Yep, we're experiencing this issue as well, we recently upgraded https://github.com/magiclabs/wagmi-magic-connector in our project from 1.1.5 to 2.0.0, which it seems also comes with a magic SDK version upgrade.

hubagaspar91 avatar Apr 17 '24 13:04 hubagaspar91

Having same issue too. we were on 8.1.0 (time for upgrade lol) and having the issue

TheGreatAlgo avatar May 24 '24 17:05 TheGreatAlgo

is there a fix to this? upgrading does not seem to help.

mjafri118 avatar Jun 18 '24 21:06 mjafri118

Hi there! this bug still occurring in 28.0.7. Is there any chance to fix that in the upcoming updates?

Wyxuch avatar Jun 25 '24 11:06 Wyxuch

Same issue here still

Bowis avatar Oct 20 '24 14:10 Bowis