react-native-root-toast icon indicating copy to clipboard operation
react-native-root-toast copied to clipboard

fixing onPress event + adding children option other than string

Open groger opened this issue 3 years ago • 4 comments
trafficstars

  • Fixed onPress event that wasn't working, it wasn't firing (Web). Issue is TouchableWithoutFeedback always needs to have child View component. So a component that composes a View isn't enough. So added an extra View around Animated.View
  • Added an option to pass either a string as children prop where we applied textStyle and textColor like before or any type of children

I tested those modifications in my project with patch-package and it's working great and shouldn't break anything with anyone who has that library installed

groger avatar Aug 15 '22 04:08 groger

+1 to this!!

adamlbailey avatar Aug 22 '22 19:08 adamlbailey

I need this too!

ClementPF avatar Aug 28 '22 22:08 ClementPF

+1

ghost avatar Aug 29 '22 19:08 ghost

Came here looking for something like this, thank you. However, (and not speaking for the maintainer) this PR is not merge-able with the changes to the lockfile and package name, etc. If you need an installable copy of your changes, I suggest making a branch on your fork for that purpose.

I also think that this could potentially be accomplished by changing the use of TouchableWithoutFeedback to Pressable, as the latter is deprecated.

bradjones1 avatar May 26 '23 18:05 bradjones1