Cloudlog icon indicating copy to clipboard operation
Cloudlog copied to clipboard

Published 20 hours ago • verified publisher icon magicbug

Reproduceable crash

Open LAwmand opened this issue 1 year ago • 7 comments

I know nothing about code.

The whole app crashes when I fully zoom out when displaying locator squares. I know it,s a stupid thing to do but ive twiddled my mousewheel the wrong way a few times. Once crashed it just freezes and is unresponsive until I hit the back button a couple of times Windows 10 on Magicbug server, same error on my desktops and laptop

To Reproduce Steps to reproduce the behaviour:

  1. Go to "Analytics" then "Gridsquares"
  2. Zoom out until it will zoom no more using mouse wheel
  3. Once zoomed out nothing works, you can't zoom back or click anything or click headings
  4. Back button gets you out of it after pressing it a few times

Expected behaviour To zoom in and out flawlessly

Desktop (please complete the following information):

  • OS: Win 10
  • Microsoft Edge
  • Version

LAwmand avatar Oct 04 '22 18:10 LAwmand

Hi. I've seen this issue myself. I think we need to specify max zoom levels to avoid this.

AndreasK79 avatar Oct 04 '22 20:10 AndreasK79

Quite likely, Leaflet gets a little upset if lots of markers are being displayed

magicbug avatar Oct 04 '22 20:10 magicbug

I think its not the markers but zoom level being 0 that causes the issue here. Up to zoom = 1 everything works fine on my end.

phl0 avatar Oct 04 '22 20:10 phl0

That narrows it down for a quick fix!

magicbug avatar Oct 04 '22 20:10 magicbug

This fixes it. Can someone test?

https://github.com/magicbug/Cloudlog/compare/station_logbooks...phl0:Cloudlog:minZoom?expand=1

phl0 avatar Oct 04 '22 20:10 phl0

Fixed it by setting minZoom to 1. So you cannot zoom out more. See https://github.com/magicbug/Cloudlog/pull/1634.

phl0 avatar Oct 04 '22 20:10 phl0

Custom map is not affected by the way. PR fixes it for gridsquares and activated gridsquares.

phl0 avatar Oct 04 '22 20:10 phl0

Thanks for the prompt and effective response phl0. Magicbug, will this be reflected on my site? Regards all, David

LAwmand avatar Oct 05 '22 07:10 LAwmand

should be reflected within the next hour just merged the fix into the codebase

magicbug avatar Oct 05 '22 13:10 magicbug

Thanks Peter, Best Regards David

On Wed, 5 Oct 2022, 14:44 Peter Goodhall, @.***> wrote:

should be reflected within the next hour just merged the fix into the codebase

— Reply to this email directly, view it on GitHub https://github.com/magicbug/Cloudlog/issues/1633#issuecomment-1268460590, or unsubscribe https://github.com/notifications/unsubscribe-auth/A2RRI6QZSTKASBWM4GH2KPDWBWA45ANCNFSM6AAAAAAQ42HSHU . You are receiving this because you authored the thread.Message ID: @.***>

LAwmand avatar Oct 05 '22 14:10 LAwmand