magewire icon indicating copy to clipboard operation
magewire copied to clipboard

V1: Add layout to fingerprint to enable layout-level Magewire components

Open gerrits-ecommerce opened this issue 1 year ago • 1 comments

This makes it possible to define a Magewire component in a page_layout file, configure a category (or CMS page, etc.) to use this layout file, and have the component function as expected.

This functionality can be tested using the module below: reproduction.zip

In the current Magewire codebase; if you configure a category to use the test layout that this module defines and load that category the initial render will succeed, but any changes will result in a 404 error because the Magewire Module cannot be found in the default catalog_category_view template.

With this change the module will function.

gerrits-ecommerce avatar Mar 18 '24 13:03 gerrits-ecommerce

As Willem and I already discussed on the Hyva Slack I'm not 100% sure what the performance impact of this change will be. My local testing seems to indicate the impact is minimal to none. But if anyone with more expertise in this area has additional input I'd be happy to hear that.

gerrits-ecommerce avatar Mar 18 '24 13:03 gerrits-ecommerce