magewire icon indicating copy to clipboard operation
magewire copied to clipboard

Breeze theme support

Open olivertar opened this issue 1 year ago • 1 comments

Support for the Breeze theme.

olivertar avatar Jan 26 '24 19:01 olivertar

Hi @olivertar,

Thanks for submitting this PR.

I'll will schedule some time to test this thoroughly asap.

wpoortman avatar Jan 26 '24 21:01 wpoortman

@olivertar,

I prefer having this in a separate compatibility module. When I'm merging this, this will be applied also to those who aren't running the Breeze theme. I can link to the compatibility module via the docs if you can provide me a link.

Let me know!

Thanks

wpoortman avatar Jul 26 '24 12:07 wpoortman

Willem

As you prefer, just comment that the modification works whether you use Hyva, Breeze or any other theme because I made Magewire only depend on Magento variables.

There is not much more documentation than the module repository https://github.com/olivertar/magewire-breeze

Best

El vie, 26 jul 2024 a las 14:35, Willem Poortman @.***>) escribió:

@olivertar https://github.com/olivertar,

I prefer having this in a separate compatibility module. When I'm merging this, this will be applied also to those who aren't running the Breeze theme. I can link to the compatibility module via the docs if you can provide me a link.

Let me know!

Thanks

— Reply to this email directly, view it on GitHub https://github.com/magewirephp/magewire/pull/146#issuecomment-2252671937, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHKHUC2SKUI4E3GOVFH4OLZOI7AVAVCNFSM6AAAAABCMTS5NSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJSGY3TCOJTG4 . You are receiving this because you were mentioned.Message ID: @.***>

olivertar avatar Jul 26 '24 14:07 olivertar