magewire icon indicating copy to clipboard operation
magewire copied to clipboard

Remove dep with symfony/http-kernel

Open jissereitsma opened this issue 2 years ago • 0 comments

As mentioned in https://github.com/magewirephp/magewire/pull/107 there is an undocumented dependency with symfony/http-kernel only for an exception that is thrown. The HttpException (https://github.com/symfony/http-kernel/blob/6.3/Exception/HttpException.php) actually inherits from \RuntimeException. This PR simply just removes the dep and throws the RuntimeException as is. Nothing fancy.

Additional comment, the reason why this issue got started is that the symfony/http-foundation package (which is a requirement for Magewire) has a require-dev dep with symfony/http-kernel (https://github.com/symfony/http-foundation/blob/6.3/composer.json#L29). If composer is installed in dev env, then this problem does not occur.

jissereitsma avatar Oct 27 '23 09:10 jissereitsma