magento-2-social-login icon indicating copy to clipboard operation
magento-2-social-login copied to clipboard

Modules requires

Open alexvais opened this issue 4 years ago • 4 comments

Hi,

Why this module require SMTP, Two Factors and Google recaptcha from mageplaza? why are them mandatory?

alexvais avatar Dec 09 '20 08:12 alexvais

Hi @alexvais

I'm Victor from Mageplaza. I would like to answer your question.

They are declared in the composer.json file. So when you use composer to install it, it will default to drag the above modules. Initially, the idea was to provide you with the most complete solution following the main module and supplementary modules.

I apologize if it causes any inconvenience. Thank you!

Best Regards, Victor

Victor-Mageplaza avatar Dec 09 '20 09:12 Victor-Mageplaza

So this module do not depend of the others? can i remove them?

alexvais avatar Dec 10 '20 12:12 alexvais

@Victor-Mageplaza

I think it's very bad practice to require modules in your composer file that are optional. I would like to urge you to remove them from the composer.json file!

If I want to install an SMTP module, I will do so, separately, from a source of my choosing.

Or as is the actual case for the current project I'm working on; it already has an SMTP module installed. Best case I'm going to have to deal with the additional bloat of an unused module but I might very well be looking at resolving module conflicts, backend user confusion, etc.

nocturnalfrog avatar Dec 24 '20 12:12 nocturnalfrog

Also delete from module.xml dependecies, because the modules are not related.

alexvais avatar Feb 23 '21 21:02 alexvais

Thank you for your contributions. We have fixed the problem in the latest version. Now when you install the new version, you won't have this problem anymore. Thank you very much!

KhietNguyen83 avatar Nov 07 '22 03:11 KhietNguyen83