magento-2-blog icon indicating copy to clipboard operation
magento-2-blog copied to clipboard

Published 20 hours ago • verified publisher icon mageplaza

Deprected explode router

Open ishiekh-dev opened this issue 2 years ago • 3 comments

[php 8.1 - explode(): Passing null to parameter #2 ($string) of type string is deprecated] so i used null coalescing operator to avoid that error

ishiekh-dev avatar Jun 29 '22 14:06 ishiekh-dev

@zenfork Thanks for the PR, I need this for a project (2.4.4/PHP8.1) and I'm using your PR as a composer patch to make it work. Unfortunately, the suggested change that you made in Controller/Router.php by renaming $ids to $routePath is needed for it to work and it is not included in the Github patch version of the PR. Could you validate your own suggestion so that it can be used while the PR gets approved by the plugin's author? Thanks a lot!

Edit: woops sorry, I meant to thank @ishiekh-dev for the PR! And @zenfork for the suggestions.

Leobaillard avatar Jul 27 '22 15:07 Leobaillard

Looks like approving the changes does not change the auto diff patch. @ishiekh-dev could you maybe include the suggestions to your PR so that the diff gets updated? Thanks!

Leobaillard avatar Aug 29 '22 12:08 Leobaillard

Ping @ishiekh-dev ?

Leobaillard avatar Sep 07 '22 08:09 Leobaillard

Hi , Thanks for your contribution. We have updated and released a new version that solves this problem. Thank you very much!

KhietNguyen83 avatar Nov 09 '22 15:11 KhietNguyen83