magento-2-blog icon indicating copy to clipboard operation
magento-2-blog copied to clipboard

End of Line sequence coding standard

Open adri2k opened this issue 4 years ago • 1 comments

I'm trying to create a patch with cweagans/composer-patches and I notice that some files have End of Line Sequence LF and other CRLF.
Is not possibile to apply diff patch on CRLF files (without --binary option trick).

I suggest to use LF standard instead of the actual mixing.

Expected result

  1. All file with LF

Actual result

  1. Some file have CRLF other LF (example Plugin/Catalog/AttributeSort.php CRLF , Plugin/InfortisTopmenu.php LF )

adri2k avatar Oct 14 '20 13:10 adri2k

Hi @adri2k , Thanks for your contribution. We will have a check and consider putting it on our roadmap.

phutx avatar Oct 15 '20 04:10 phutx