magento-2-blog icon indicating copy to clipboard operation
magento-2-blog copied to clipboard

Published 20 hours ago • verified publisher icon mageplaza

Use mb_strlen instead of strlen

Open alinalexandru opened this issue 5 years ago • 3 comments

We faced with a strange situation. On homepage, on recent posts, the short description was not trimmed correctly. The last character was UTF-8.

Description

Strlen function is not save in UTF-8 content. This pull request does not have a big impact in module functionality

Contribution checklist

  • [ ] Pull request has a meaningful description of its purpose
  • [ ] All commits are accompanied by meaningful commit messages
  • [ ] All new or changed code is covered with unit/integration tests (if applicable)

alinalexandru avatar Jun 20 '19 11:06 alinalexandru

Hi @alinalexandru,

Thanks for your contribution. This is necessary for our Blog Extension. We highly appreciate any idea, suggestion, and comment like yours and consider them in our next improvement to make our products better. Thank you very much!

viethung512 avatar Jun 21 '19 02:06 viethung512

@NgoDuVietHung97 I saw that some tests have failed. Is because of my PR?

alinalexandru avatar Jun 21 '19 07:06 alinalexandru

Hi @alinalexandru,

We will look into this issue and decide whether to merge into the repository. Thank you very much for your contribution!

viethung512 avatar Jun 21 '19 07:06 viethung512

I'm Justin from Mageplaza. Thank you for your interest in our SocialLogin module and for bringing this issue to us. Feedback like this helps us constantly improve this extension and the customer experience by knowing what we're doing right and what we can do. So I appreciate you taking the time to send us this helpful answer. We will review and update in new version.

Again, thanks for your important contribution here. Our gratitude has no limits.

KhietNguyen83 avatar Nov 09 '22 13:11 KhietNguyen83