pwa-studio icon indicating copy to clipboard operation
pwa-studio copied to clipboard

[bug]: fix typo "rame-src" should be "frame-src"

Open brendanfalkowski opened this issue 9 months ago • 2 comments

Describe the bug

This merge introduced a typo: https://github.com/magento/pwa-studio/commit/6301db326f3e3eb78aa3ce3dc3843b1811d7edf7#diff-c495636b3768d54005771e15b18d42639e212f8f74c7ca5417b842681374af62

frame-src became rame-src which is wrong.

Please let us know what packages this bug is in regards to:

  • [ ] venia-concept
  • [ ] venia-ui
  • [x] extensions
  • [ ] pwa-buildpack
  • [ ] peregrine
  • [ ] pwa-devdocs
  • [ ] upward-js
  • [ ] upward-spec
  • [ ] create-pwa

brendanfalkowski avatar Mar 11 '25 21:03 brendanfalkowski

Hi @brendanfalkowski. Thank you for your report. To speed up processing of this issue, make sure that you provided sufficient information. Add a comment to assign the issue: @magento I am working on this


Join Magento Community Engineering Slack and ask your questions in #github channel.

m2-assistant[bot] avatar Mar 11 '25 21:03 m2-assistant[bot]

@magento I am working on this

brendanfalkowski avatar Mar 11 '25 21:03 brendanfalkowski

@adobe export issue to JIRA project PWA as Bug

glo82145 avatar Jul 17 '25 07:07 glo82145

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/PWA-3535 is successfully created for this GitHub issue.

github-jira-sync-bot avatar Jul 17 '25 07:07 github-jira-sync-bot

This change is already applied in the upward.yml file as a part of our previous release. https://github.com/magento/pwa-studio/blob/develop/packages/extensions/upward-security-headers/upward.yml Hence closing this ticket, feel free to reopen if it occurs again.

del22123 avatar Aug 20 '25 06:08 del22123