pwa-studio icon indicating copy to clipboard operation
pwa-studio copied to clipboard

[bug]: Invalid auth middleware clearTimeout implementation

Open rafalslowik opened this issue 10 months ago • 1 comments

Describe the bug

Invalid auth middleware clearTimeout implementation. Function clearTimeout accept number type, not array as is.

To reproduce

Steps to reproduce the behavior:

  • Impossible to reproduce. Found it when checking how function work.

Expected behavior

Cleared timeout to avoid memory leak.

Screenshots

Image

Possible solutions

Use array destructuring on Map to get valid number type field to clear interval.

Image

Debug Report

Please complete the following device information:

Please let us know what packages this bug is in regards to:

  • [ ] venia-concept
  • [ ] venia-ui
  • [ ] pwa-buildpack
  • [x] peregrine
  • [ ] pwa-devdocs
  • [ ] upward-js
  • [ ] upward-spec
  • [ ] create-pwa

rafalslowik avatar Jan 22 '25 09:01 rafalslowik

Hi @rafalslowik. Thank you for your report. To speed up processing of this issue, make sure that you provided sufficient information. Add a comment to assign the issue: @magento I am working on this


Join Magento Community Engineering Slack and ask your questions in #github channel.

m2-assistant[bot] avatar Jan 22 '25 09:01 m2-assistant[bot]

@adobe export issue to JIRA project PWA as Bug

glo82145 avatar Jul 17 '25 07:07 glo82145

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/PWA-3538 is successfully created for this GitHub issue.

github-jira-sync-bot avatar Jul 17 '25 07:07 github-jira-sync-bot

This issue is already fixed in PR https://github.com/magento/pwa-studio/pull/4550 , hence closing this issue. Please feel free to reopen in case of any update.

glo82145 avatar Nov 25 '25 16:11 glo82145