pwa-studio icon indicating copy to clipboard operation
pwa-studio copied to clipboard

fix error when getting product thumbnails by url key

Open vacla opened this issue 1 year ago • 1 comments

Description

Made it so that it won't error anymore on a null value in an array when sending it, as Magento backend will just ignore this and send an empty item for this back.

Related Issue

Closes #4307 .

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

  1. Login in account
  2. Place order with 1 product
  3. Delete this product out of magento
  4. Go to order history page
  5. See no error anymore in console

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

vacla avatar Aug 04 '24 22:08 vacla

Fails
:no_entry_sign: A version label is required. A maintainer must add one.
:no_entry_sign: Missing information in PR. Please fill out the "Description" section.
Warnings
:warning: Found the word "TODO" in the PR description. Just letting you know incase you forgot :)
Messages
:book: DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
:book:

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

If your PR is missing information, check against the original template here. At a minimum you must have the section headers from the template and provide some information in each section.

Generated by :no_entry_sign: dangerJS against 940b5d58389beb9826d260bec10508df1eb7642e

pwa-studio-bot avatar Aug 04 '24 22:08 pwa-studio-bot

This issue has been fixed and merged, hence closing this PR

glo82145 avatar Aug 11 '25 08:08 glo82145