Error when getting thumbnails on order row for deleted products

[vacla]

Describe the bug

When getting orders with deleted products, it gives an error here: https://github.com/magento/pwa-studio/blob/a3faf3f3a3f05d5627e642f7a3d976e2e0fa56df/packages/peregrine/lib/talons/OrderHistoryPage/orderRow.gql.js#L14

This is the error:

{
    "errors": [
        {
            "message": "Variable \"$urlKeys\" got invalid value [null,null]; Expected non-nullable type String! not to be null at value[0].\n\nVariable \"$urlKeys\" got invalid value [null,null]; Expected non-nullable type String! not to be null at value[1].",
            "extensions": {
                "category": "graphql"
            }
        }
    ]
}

To reproduce

Steps to reproduce the behavior:

1. Login in account
2. Place order with 1 product
3. Delete this product out of magento
4. Go to order history page
5. See error in console

Expected behavior

No error

Possible solutions

Make this an optional string: https://github.com/magento/pwa-studio/blob/a3faf3f3a3f05d5627e642f7a3d976e2e0fa56df/packages/peregrine/lib/talons/OrderHistoryPage/orderRow.gql.js#L14

Debug Report

ℹ Inspecting Dependencies Found 9 https://github.com/magento dependencies in yarn.lock @magento/pwa-buildpack @ 11.4.3 @adobe/apollo-link-mutation-queue @ 1.0.2 @magento/babel-preset-peregrine @ 1.2.3 @magento/eslint-config @ 1.5.3 @magento/pagebuilder @ 8.2.1 @magento/peregrine @ 13.2.1 @magento/pwa-theme-venia @ 1.4.0 @magento/venia-adobe-data-layer @ 1.0.0 @magento/venia-ui @ 10.3.0

ℹ Inspecting Magento Backend Not using sample backend. Backend is UP!

ℹ Inspecting System OS: https://github.com/magento/pwa-studio/pull/39-Ubuntu SMP PREEMPT_DYNAMIC Fri Jul 5 21:49:14 UTC 2024 Node Version: v16.20.2 NPM Version: 8.19.4

Please complete the following device information:

• Device [e.g. iPhone6, PC, Mac, Pixel3]: PC
• Browser [e.g. Chrome, Safari]: Chrome
• Browser Version [e.g. 22]: 127.0.6533.72
• Magento Version [e.g Adobe Commerce 2.4]: commerce 2.4.5-p8

Please let us know what packages this bug is in regards to:

• [ ] venia-concept
• [ ] venia-ui
• [ ] pwa-buildpack
• [x] peregrine
• [ ] pwa-devdocs
• [ ] upward-js
• [ ] upward-spec
• [ ] create-pwa

[m2-assistant[bot]]

Hi @vacla. Thank you for your report. To speed up processing of this issue, make sure that you provided sufficient information. Add a comment to assign the issue: @magento I am working on this

---

Join Magento Community Engineering Slack and ask your questions in #github channel.

[glo82145]

@adobe export issue to JIRA project PWA as Bug

[github-jira-sync-bot]

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/PWA-3359 is successfully created for this GitHub issue.

[del15881]

Hi @vacla

Thank you for bringing this up!

Could you please clarify why you are deleting a product from the backend and checking the order history for deleted products ?

we are curious if this is a specific case for any of your clients or if it has caused issues in one of your projects.

Thanks.

[vacla]

@del15881 We are removing them when they are no longer in the collection available. Our client wants us to show the history of all previously placed orders to the customers, all info is always available in the orders table that is needed to show this.

If the product wasn't available we would want to show the placeholder image what is currently not possible due to this bug as it will error at that moment.