pwa-studio icon indicating copy to clipboard operation
pwa-studio copied to clipboard

[bug]: Search products by category from searchBar doesn't work

Open joseamietta opened this issue 1 year ago • 11 comments

Describe the bug

Search products by category from searchBar doesn't work https://venia.magento.com/search.html?query=shirt&category_id%5Bfilter%5D=Tops%2CMTg%3D&page=1

The attribute category_id is deprecated, should replace by category_uid

To reproduce

Steps to reproduce the behavior:

  1. Open top SearchBar
  2. Type 'shirt'
  3. Click on 'shirt on Top'
  4. The search.html page show No results found!
  5. if replace category_id with category_uid from URL, It's works and sidebar category filter was actived

Expected behavior

Able to search products by category from searchBar

Screenshots

image Screenshot from 2023-12-22 11-47-34 Screenshot from 2023-12-22 11-48-00

Possible solutions

in file node_modules/@magento/peregrine/lib/talons/SearchBar/useSuggestedCategory.js, line 12 replace category_id[filter] by category_uid[filter]

Please complete the following device information:

  • Device [e.g. Lenovo Thinkpad, Notebook, Ubuntu 22.04]:
  • Browser [e.g. Chrome]:
  • Browser Version [e.g. 120.0.6099.109]:
  • Magento Version [e.g Adobe Commerce 2.4.6-p3]:

Please let us know what packages this bug is in regards to:

  • [ ] venia-concept
  • [ ] venia-ui
  • [ ] pwa-buildpack
  • [x] peregrine
  • [ ] pwa-devdocs
  • [ ] upward-js
  • [ ] upward-spec
  • [ ] create-pwa

joseamietta avatar Dec 22 '23 14:12 joseamietta

Hi @joseamietta. Thank you for your report. To speed up processing of this issue, make sure that you provided sufficient information. Add a comment to assign the issue: @magento I am working on this


Join Magento Community Engineering Slack and ask your questions in #github channel.

m2-assistant[bot] avatar Dec 22 '23 14:12 m2-assistant[bot]

@magento I am working on this

joseamietta avatar Dec 22 '23 15:12 joseamietta

Hi @joseamietta! :wave: Thank you for collaboration. Only members of Community Contributors Team are allowed to be assigned to the issue. Please use @magento add to contributors team command to join Contributors team.

m2-assistant[bot] avatar Dec 22 '23 15:12 m2-assistant[bot]

@magento add to contributors team

joseamietta avatar Dec 22 '23 15:12 joseamietta

Hi @joseamietta! :wave: Thank you for joining. Please accept team invitation :point_right: here :point_left: and add your comment one more time.

m2-assistant[bot] avatar Dec 22 '23 15:12 m2-assistant[bot]

@magento I am working on this

joseamietta avatar Dec 22 '23 15:12 joseamietta

@magento I am working on this

Hi @RaghavendraTirumalasetti! :wave: Thank you for collaboration. Only members of Community Contributors Team are allowed to be assigned to the issue. Please use @magento add to contributors team command to join Contributors team.

m2-assistant[bot] avatar Jan 03 '24 08:01 m2-assistant[bot]

Issue is reproducible with the steps Mentioned. Hence Conforming the issue.

@adobe export issue to JIRA project PWA as Bug

glo82145 avatar Feb 20 '24 06:02 glo82145

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/PWA-3237 is successfully created for this GitHub issue.

github-jira-sync-bot avatar Feb 20 '24 06:02 github-jira-sync-bot