pwa-studio
pwa-studio copied to clipboard
[bug]: Page Builder column responsive styles break with CMS block in page
Describe the bug
When a CMS page has columns with responsive styles, and also has a CMS block with colums, the responsive styles for the page are no longer treated. This is because the CMS Block has it's own styles which override the media styles for the page.
To reproduce
Steps to reproduce the behavior:
CMS Block setup
- Create a CMS Block
- Add columns to CMS block
- Add basic image to the columns of CMS block
Page Setup
- Create CMS page
- Add Row + Columns to page
- Set the min-height for desktop on the columns
- Set an image for desktop on the columns
- Set the min-height for mobile to something different on the columns
- Set a different image for mobile on columns
- Add a row to the page
- Add CMS block into row
Expected behavior
Desktop and mobile styling/images should differ on the page's columns
Actual behavior
Images and min-height stays the same across all media
Possible solutions
PR incoming. Media styles override with the last style tag.
Note: Also requires https://github.com/magento/pwa-studio/pull/4028 otherwise columns don't work
Please let us know what packages this bug is in regards to:
- [ ]
venia-concept - [ ]
venia-ui - [ ]
pwa-buildpack - [ ]
peregrine - [ ]
pwa-devdocs - [ ]
upward-js - [ ]
upward-spec - [ ]
create-pwa - [x]
pagebuilder
Hi @justinconabree. Thank you for your report.
To speed up processing of this issue, make sure that you provided sufficient information.
Add a comment to assign the issue: @magento I am working on this
Join Magento Community Engineering Slack and ask your questions in #github channel.
@magento I am working on this
Hi @justinconabree ,
As per retesting the issue we are not able to reproduce it and working fine.
Followed steps to reproduce :
- Create CMS page i.e.- Test-page
- Added Row + Columns to page
- Added the min-height (i.e.-600px ) for desktop on the columns.
- Added an image for desktop on the columns
- Added min-height for mobile (i.e.-200px ) for the columns
- Added different image for mobile on columns
- Added a row to the page
- Added CMS block into row
- Added columns to CMS block
- Added basic image to the columns of CMS block
For recording follow the link : https://adobe-my.sharepoint.com/:v:/r/personal/glo50745_adobe_com/Documents/Screen%20Recording%202023-05-11%20at%2010.49.58%20AM.mov?csf=1&web=1&e=dBsCP8
We waited for more than 14 days for update on this issue, hence we are closing it.
Please feel free to reopen if you are still have any update on the same.
@adobe export issue to JIRA project PWA as Story
:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/PWA-3286 is successfully created for this GitHub issue.
As we have not received any update on this issue, hence we are closing it. Please feel free to reopen in case of any update.