pwa-studio icon indicating copy to clipboard operation
pwa-studio copied to clipboard

DONT MERGE Test Branch

Open dpatil-magento opened this issue 2 years ago • 6 comments

Description

TODO: Describe your changes in detail here.

Related Issue

Closes #ISSUE_NUMBER.

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

dpatil-magento avatar Feb 08 '23 15:02 dpatil-magento

Fails
:no_entry_sign:

node failed.

:no_entry_sign: A version label is required. A maintainer must add one.
:no_entry_sign:

Unit tests in the following files did not pass 😔. All tests must pass before this PR can be merged

  • packages/peregrine/lib/hooks/useCustomerWishlistSkus/__tests__/useCustomerWishlistSkus.spec.js
:no_entry_sign:

No linked issue found. Please link a relevant open issue by adding the text "closes #<issue_number>" or "closes JIRA-<issue_number>" in your PR.

:no_entry_sign: Missing information in PR. Please fill out the "Description" section.
Warnings
:warning: Found the word "TODO" in the PR description. Just letting you know incase you forgot :)
Messages
:book: DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
:book:

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Log

ERROR ON TASK: unitTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

If your PR is missing information, check against the original template here. At a minimum you must have the section headers from the template and provide some information in each section.

Generated by :no_entry_sign: dangerJS against 03009f80ac85a8da4bee0aaf8e04f0504ac646fd

pwa-studio-bot avatar Feb 08 '23 16:02 pwa-studio-bot

run cypress

dpatil-magento avatar Feb 13 '23 17:02 dpatil-magento

Successfully started codebuild job for cypress

pwa-test-bot[bot] avatar Feb 13 '23 17:02 pwa-test-bot[bot]

Fails
:no_entry_sign:

node failed.

:no_entry_sign:

Cypress tests in the following files did not pass 😔. All tests must pass before this PR can be merged

  • user should be able to add and remove promotions from cart:
    • AssertionError: Timed out retrying after 30000ms: Expected not to exist in the DOM, but it was continuously found.
  • user should be able to update their address book:
    • CypressError: Timed out retrying after 60000ms: `cy.wait()` timed out waiting `60000ms` for the 1st request to the route: `gqlSignInAfterCreateMutation`. No request ever occurred.

      https://on.cypress.io/wait

Log

ERROR ON TASK: cypressTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by :no_entry_sign: dangerJS against 03009f80ac85a8da4bee0aaf8e04f0504ac646fd

pwa-studio-bot avatar Feb 13 '23 17:02 pwa-studio-bot

run cypress

dpatil-magento avatar Feb 22 '23 06:02 dpatil-magento

Successfully started codebuild job for cypress

pwa-test-bot[bot] avatar Feb 22 '23 06:02 pwa-test-bot[bot]