pwa-studio icon indicating copy to clipboard operation
pwa-studio copied to clipboard

[bug]: Page Builder column-line content type is not supported, this content will not be rendered.

Open gijsvds opened this issue 2 years ago • 8 comments

Describe the bug

Ever since we upgraded to Magento 2.4.5 our Pagebuilder content that uses a column has stopped working. We tested this on a clean Pwa Studio install with a Magento 2.4.5 backend attached to it.

To reproduce

Steps to reproduce the behavior:

  1. install a fresh pwa studio environment
  2. attach it to a magento 2.4.5 backend
  3. use a column in pagebuilder on your homepage (or any other page)
  4. See error

Expected behavior

I expect to see the columns and their content I added using pagebuilder in the frontend application.

Screenshots

Landing page backend used for my current homepage: image

Landing page frontend used for my current homepage: image

error in console: image

Possible solutions

Extend the @magento/pagebuilder/lib/ContentTypes with the new column-line type.

Debug Report

yarn build:report output : yarn run v1.22.17 $ buildpack generate-build-report ℹ Generating build report for [email protected]. This may take a moment.

ℹ Inspecting Dependencies Found 9 @magento dependencies in yarn.lock @magento/pwa-buildpack @ 11.4.0 @adobe/apollo-link-mutation-queue @ 1.0.2 @magento/babel-preset-peregrine @ 1.2.1 @magento/eslint-config @ 1.5.3 @magento/pagebuilder @ 7.4.1 @magento/peregrine @ 12.5.1 @magento/pwa-theme-venia @ 1.3.0 @magento/upward-security-headers @ 1.0.10 @magento/venia-ui @ 9.6.0

ℹ Inspecting Magento Backend Not using sample backend. Backend is UP!

ℹ Inspecting System OS: Darwin Kernel Version 21.6.0: Sat Jun 18 17:07:25 PDT 2022; root:xnu-8020.140.41~1/RELEASE_X86_64 Node Version: v16.15.0 NPM Version: 8.5.5

✨ Done in 4.25s.

Please complete the following device information:

  • Device [e.g. iPhone6, PC, Mac, Pixel3]: Mac
  • Browser [e.g. Chrome, Safari]: Chrome
  • Browser Version [e.g. 22]: Version 104.0.5112.101 (Official Build) (x86_64)
  • Magento Version [e.g Adobe Commerce 2.4]: Magento ver. 2.4.5

Please let us know what packages this bug is in regards to:

  • [ ] venia-concept
  • [x] venia-ui
  • [x] pagebuilder
  • [ ] pwa-buildpack
  • [ ] peregrine
  • [ ] pwa-devdocs
  • [ ] upward-js
  • [ ] upward-spec
  • [ ] create-pwa

gijsvds avatar Sep 01 '22 09:09 gijsvds

Hi @gijsvds. Thank you for your report. To speed up processing of this issue, make sure that you provided sufficient information.

Add a comment to assign the issue: @magento I am working on this


m2-assistant[bot] avatar Sep 01 '22 09:09 m2-assistant[bot]

@adobe export issue to JIRA project PWA as Bug

anthoula avatar Sep 06 '22 15:09 anthoula

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/PWA-2986 is successfully created for this GitHub issue.

github-jira-sync-bot avatar Sep 06 '22 15:09 github-jira-sync-bot

@gijsvds - Thanks for the input. Is column-line an extension by chance? This is not part of the base supported content types.

anthoula avatar Sep 06 '22 17:09 anthoula

@anthoula - Thank you for responding. No, it shouldn't be an extension. It may have something to do with this new feature in 2.4.5: image

maybe the name of the column-type was changed there? I'm not sure but I do know the issue started since we upgraded to magento 2.4.5

gijsvds avatar Sep 07 '22 13:09 gijsvds

Have same issue, when possible fix will be released?

yaroslav-qlicks avatar Sep 12 '22 14:09 yaroslav-qlicks

Have same issue, when possible fix will be released?

I added a quick fix on my project (I know, it's a dirty fix, but it allowed us continue work on the project with minimal time spent):

  1. Override config
module.exports = componentOverride = {
...
    ['@magento/pagebuilder/lib/config.js']: 'src/components/Pagebuilder/config.js'
...
};
  1. Added "column-line" and used ColumnGroup for this component
...
    'column-group': {
        configAggregator: columnGroupConfigAggregator,
        component: ColumnGroup
    },
+    'column-line': {
+        configAggregator: columnGroupConfigAggregator,
+        component: ColumnGroup
+    },
    image: {
        configAggregator: imageConfigAggregator,
...

oleksiyzestlogic avatar Sep 12 '22 16:09 oleksiyzestlogic

@oleksiyzestlogic Thank you for providing this temporary solution. We may use this in our project aswel until a fix is provided in pwa-studio.

gijsvds avatar Sep 13 '22 07:09 gijsvds

@oleksiyzestlogic Thank you for this temporary solution. It helped resolve my issue temporary. But waiting from @pwa-studio-bot to release its fixes on repo only.

sanganinamrata avatar Sep 28 '22 06:09 sanganinamrata

Have same issue, when possible fix will be released?

I added a quick fix on my project (I know, it's a dirty fix, but it allowed us continue work on the project with minimal time spent):

  1. Override config
module.exports = componentOverride = {
...
    ['@magento/pagebuilder/lib/config.js']: 'src/components/Pagebuilder/config.js'
...
};

Can you please specify in witch file we can add this override?

apomili avatar Mar 02 '23 09:03 apomili