pwa-studio icon indicating copy to clipboard operation
pwa-studio copied to clipboard

AC-2498-Images lacking meaningful alternative text. (Account - Order …

Open glo82145 opened this issue 2 years ago • 2 comments

…History)

Description

Reproduction Steps Sign In > select "Order History" from account dropdown - [NODE][body>div:nth-of-type(1)>:nth-child(1)>:nth-child(3)]

  1. With JAWS operating, use the down arrow key to read through a collapsed preview of an order with multiple products.

Actual Behavior In the Order History list, when an order accordion is closed, the product images do not provide meaningful alternative text - each image listed has alt text of "Main". The information conveyed by these images - i.e. a quick view of products included in the order - is not provided to screen reader users.

Note that there are two elements for each product image (for eager and lazy loading); although the eager image is visually hidden, it is still available to assistive technology. As a result, the same alt text for each product is announced twice.

Expected Behavior Images that convey information must provide descriptive textual alternatives. In this case, the alt text for each image should be brief but identifying image about the product, likely the product name.

Ensure that content intended to be hidden from all users, such as the eager image once the lazy image loads, is also hidden from assistive technology.

Related Issue

Closes #AC-2498.

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

Resolved issues:

  1. [x] resolves magento/pwa-studio#3946: AC-2498-Images lacking meaningful alternative text. (Account - Order …

glo82145 avatar Aug 26 '22 07:08 glo82145

Messages
:book:

Associated JIRA tickets: AC-2498.

:book: DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
:book:

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by :no_entry_sign: dangerJS against 8531cb4af5498cb874ffa6e15693c0a5158229bd

pwa-studio-bot avatar Aug 26 '22 07:08 pwa-studio-bot

@magento create issue from PR

anthoula avatar Aug 29 '22 14:08 anthoula

run cypress

dpatil-magento avatar Nov 16 '22 17:11 dpatil-magento

Successfully started codebuild job for cypress

pwa-test-bot[bot] avatar Nov 16 '22 17:11 pwa-test-bot[bot]

Fails
:no_entry_sign:

node failed.

:no_entry_sign:

Cypress tests in the following files did not pass 😔. All tests must pass before this PR can be merged

  • user should be able to update their address book:
    • CypressError: Timed out retrying after 60000ms: `cy.wait()` timed out waiting `60000ms` for the 1st request to the route: `gqlSignInAfterCreateMutation`. No request ever occurred.

      https://on.cypress.io/wait

Log

ERROR ON TASK: cypressTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by :no_entry_sign: dangerJS against 8531cb4af5498cb874ffa6e15693c0a5158229bd

pwa-studio-bot avatar Nov 16 '22 18:11 pwa-studio-bot

QA Approved

dpatil-magento avatar Nov 16 '22 18:11 dpatil-magento