pwa-studio
pwa-studio copied to clipboard
AC-2498-Images lacking meaningful alternative text. (Account - Order …
…History)
Description
Reproduction Steps Sign In > select "Order History" from account dropdown - [NODE][body>div:nth-of-type(1)>:nth-child(1)>:nth-child(3)]
- With JAWS operating, use the down arrow key to read through a collapsed preview of an order with multiple products.
Actual Behavior In the Order History list, when an order accordion is closed, the product images do not provide meaningful alternative text - each image listed has alt text of "Main". The information conveyed by these images - i.e. a quick view of products included in the order - is not provided to screen reader users.
Note that there are two elements for each product image (for eager and lazy loading); although the eager image is visually hidden, it is still available to assistive technology. As a result, the same alt text for each product is announced twice.
Expected Behavior Images that convey information must provide descriptive textual alternatives. In this case, the alt text for each image should be brief but identifying image about the product, likely the product name.
Ensure that content intended to be hidden from all users, such as the eager image once the lazy image loads, is also hidden from assistive technology.
Related Issue
Closes #AC-2498.
Acceptance
Verification Stakeholders
Specification
Verification Steps
Test scenario(s) for direct fix/feature
Test scenario(s) for any existing impacted features/areas
Test scenario(s) for any Magento Backend Supported Configurations
Is Browser/Device testing needed?
Any ad-hoc/edge case scenarios that need to be considered?
Screenshots / Screen Captures (if appropriate)
Breaking Changes (if any)
Checklist
- I have added tests to cover my changes, if necessary.
- I have added translations for new strings, if necessary.
- I have updated the documentation accordingly, if necessary.
Resolved issues:
- [x] resolves magento/pwa-studio#3946: AC-2498-Images lacking meaningful alternative text. (Account - Order …
Messages | |
---|---|
:book: |
Associated JIRA tickets: AC-2498. |
:book: | DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed). |
:book: |
Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete. |
Generated by :no_entry_sign: dangerJS against 8531cb4af5498cb874ffa6e15693c0a5158229bd
@magento create issue from PR
run cypress
Successfully started codebuild job for cypress
Fails | |
---|---|
:no_entry_sign: |
|
:no_entry_sign: |
Cypress tests in the following files did not pass 😔. All tests must pass before this PR can be merged
|
Log
ERROR ON TASK: cypressTests
Error: Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json
Generated by :no_entry_sign: dangerJS against 8531cb4af5498cb874ffa6e15693c0a5158229bd
QA Approved