pwa-studio
pwa-studio copied to clipboard
Fixes on this PR: AC-2480::Flyout panels do not trap focus while open #3805
Description
Fixing https://github.com/magento/pwa-studio/pull/3805 PR based on my comment https://github.com/magento/pwa-studio/pull/3805#issuecomment-1226876005
closes #3943
Closes https://jira.corp.adobe.com/browse/ACSFT-48
Acceptance
Verification Stakeholders
Specification
Verification Steps
Test scenario(s) for direct fix/feature
Test scenario(s) for any existing impacted features/areas
Test scenario(s) for any Magento Backend Supported Configurations
Is Browser/Device testing needed?
Any ad-hoc/edge case scenarios that need to be considered?
Screenshots / Screen Captures (if appropriate)
Breaking Changes (if any)
Checklist
- I have added tests to cover my changes, if necessary.
- I have added translations for new strings, if necessary.
- I have updated the documentation accordingly, if necessary.
Messages | |
---|---|
:book: | DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed). |
:book: |
Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete. |
Generated by :no_entry_sign: dangerJS against acdde28d6d6a70c17a176ae43bc8ed02ab56e913
@sanganinamrata Can following error also be taken care part of this PR?
Warning: Failed prop type: Invalid prop `tabIndex` of type `string` supplied to `Tree`, expected `function`.
Hey @sanganinamrata , Thanks for your contribution! We are looking to include this in our upcoming release.
Can following error also be taken care part of this PR?
Warning:` Failed prop type: Invalid prop `tabIndex` of type `string` supplied to `Tree`, expected `function`.
run cypress
Successfully started codebuild job for cypress