pwa-studio icon indicating copy to clipboard operation
pwa-studio copied to clipboard

Fixes on this PR: AC-2480::Flyout panels do not trap focus while open #3805

Open sanganinamrata opened this issue 2 years ago • 3 comments

Description

Fixing https://github.com/magento/pwa-studio/pull/3805 PR based on my comment https://github.com/magento/pwa-studio/pull/3805#issuecomment-1226876005

closes #3943

Closes https://jira.corp.adobe.com/browse/ACSFT-48

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

sanganinamrata avatar Aug 25 '22 08:08 sanganinamrata

Messages
:book: DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
:book:

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by :no_entry_sign: dangerJS against acdde28d6d6a70c17a176ae43bc8ed02ab56e913

pwa-studio-bot avatar Aug 25 '22 08:08 pwa-studio-bot

@sanganinamrata Can following error also be taken care part of this PR?

Warning: Failed prop type: Invalid prop `tabIndex` of type `string` supplied to `Tree`, expected `function`.

dpatil-magento avatar Sep 16 '22 02:09 dpatil-magento

Hey @sanganinamrata , Thanks for your contribution! We are looking to include this in our upcoming release.

Can following error also be taken care part of this PR?

Warning:` Failed prop type: Invalid prop `tabIndex` of type `string` supplied to `Tree`, expected `function`.

anthoula avatar Sep 20 '22 16:09 anthoula

run cypress

dpatil-magento avatar Sep 30 '22 21:09 dpatil-magento

Successfully started codebuild job for cypress

pwa-test-bot[bot] avatar Sep 30 '22 21:09 pwa-test-bot[bot]