AC-2488::'Has Video' checkboxes do not provide descriptive labels. (S…

[glo82145]

…earch Results)

Description

Reproduction Steps search "short" - [NODE][body>div:nth-of-type(1)>:nth-child(1)>:nth-child(3)]

1. Press Tab to move through the content.
2. When keyboard focus is on "Filter" button, press Enter or Space to activate it.
3. Press Tab through "Filter" menu and once focus is on "Has Video" press Enter.

Actual Behavior "Has Video" checkboxes do not provide descriptive labels. The labels for these checkboxes are "0" and "1".

When checkbox labels are not descriptive, screen reader users and users with cognitive disabilities will not be able to discern the specific purpose of each checkbox.

Expected Behavior Ensure that the labels are descriptive.TODO: Describe your changes in detail here.

Related Issue

Closes https://jira.corp.adobe.com/browse/AC-2488

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

• I have added tests to cover my changes, if necessary.
• I have added translations for new strings, if necessary.
• I have updated the documentation accordingly, if necessary.

Resolved issues:

1. [x] resolves magento/pwa-studio#3947: AC-2488::'Has Video' checkboxes do not provide descriptive labels. (S…

[pwa-studio-bot]

	Messages
:book:	Associated JIRA tickets: AC-2488.
:book:	DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
:book:	Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by :no_entry_sign: dangerJS against d709ddbceaaa8260906dc467607c5b61c9db278f

[anthoula]

@magento create issue from PR

[devpatil7]

run cypress

[pwa-test-bot[bot]]

Successfully started codebuild job for cypress

[pwa-studio-bot]

	Fails
:no_entry_sign:	node failed.
:no_entry_sign:	Cypress tests in the following files did not pass 😔. All tests must pass before this PR can be merged user should be able to use radio-boolean filter results in Category and Search pages: AssertionError: Timed out retrying after 30000ms: expected '[ , 1 more... ]' to contain 'Has Video:No' user should be able to update their address book: CypressError: Timed out retrying after 60000ms: `cy.wait()` timed out waiting `60000ms` for the 1st request to the route: `gqlSignInAfterCreateMutation`. No request ever occurred. https://on.cypress.io/wait

Log

ERROR ON TASK: cypressTests

Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by :no_entry_sign: dangerJS against 328a3c5b33b323c581967faf614d9d9b34bf96c1

[devpatil7]

run cypress @e2e

[pwa-test-bot[bot]]

Successfully started codebuild job for cypress with tags @e2e

[devpatil7]

run cypress

[pwa-test-bot[bot]]

Successfully started codebuild job for cypress

[devpatil7]

run cypress

[pwa-test-bot[bot]]

Successfully started codebuild job for cypress

[devpatil7]

@glo82145 I'm confused on what this fix is about. Its breaking a better experience already on https://develop.pwa-venia.com/ . When focus is on say No the existing aria-label="Apply filter "Has Video:No"." is now aria-label="Apply filter "Has Video:"." which does not give any additional info , instead its removing useful text as well. please check.

[glo82145]

@glo82145 I'm confused on what this fix is about. Its breaking a better experience already on https://develop.pwa-venia.com/ . When focus is on say No the existing aria-label="Apply filter "Has Video:No"." is now aria-label="Apply filter "Has Video:"." which does not give any additional info , instead its removing useful text as well. please check.

@dpatil-magento Earlier on develop site, it is announcing two 'No' or 'Yes' on focus on 'has video' Hence to remove one Yes / No we have applied this fix

[devpatil7]

@glo82145 I'm checking in Mac default Voice Over tool and on this pr its announcing as Selected, Radio button, 1 of 2, Apply Filter, Has Video. It does not say Yes/No anymore. But on develop it says Selected, Radio button, 1 of 2, Apply Filter, Has Video Yes . Cann you please double check once?

[anthoula]

As this change removes voiceover description for Has Video on Mac, we are closing this ticket. The voiceover announces as expected on develop.pwa-magento.com for the Has Video filter.