pwa-studio icon indicating copy to clipboard operation
pwa-studio copied to clipboard

AC-3522::Product search result with items count is not being read by …

Open glo82145 opened this issue 3 years ago • 8 comments

Description

product search result with items count is not being read by screen reader

Pre Conditions:

Have Venia setup working with Magento 2.4.5-alpha2 in the local. Have sample data available in the instance Have Google chrome screen reader extension enabled and working. Steps to reproduce:

Keeping extension enabled, open the venia front end in the chrome browser. Tab the focus to search button in the home page. Press return key from the keyboard and input with the text that results with items found. (ex: carina) Expected: Screen reader should announce the total items found in the searched result.

Actual: Randomly announcing the text from left side filters options sometimes or sort items dropdown, as such.

Related Issue

Closes #AC-3522 Closes #PWA-2972

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

Resolved issues:

  1. [x] resolves magento/pwa-studio#3938: AC-3522::Product search result with items count is not being read by …

glo82145 avatar Aug 18 '22 12:08 glo82145

Messages
:book:

Associated JIRA tickets: AC-3522.

:book: DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
:book:

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by :no_entry_sign: dangerJS against 2ad64f6fd38da5cffdf91494754cbe788fb2eff7

pwa-studio-bot avatar Aug 18 '22 12:08 pwa-studio-bot

@magento create issue from PR

anthoula avatar Aug 22 '22 17:08 anthoula

Hello @glo82145, Thanks for your PR. Would you please resolve the conflicting files?

anthoula avatar Sep 13 '22 21:09 anthoula

Hello @glo82145, Thanks for your PR. Would you please resolve the conflicting files?

Hi @anthoula .. This has been resolved

glo82145 avatar Sep 14 '22 08:09 glo82145

run cypress

devpatil7 avatar Sep 19 '22 15:09 devpatil7

Successfully started codebuild job for cypress

pwa-test-bot[bot] avatar Sep 19 '22 15:09 pwa-test-bot[bot]

@glo82145 Still search result item count not announced, please check.

devpatil7 avatar Sep 19 '22 15:09 devpatil7

run cypress

devpatil7 avatar Sep 28 '22 03:09 devpatil7

Successfully started codebuild job for cypress

pwa-test-bot[bot] avatar Sep 28 '22 03:09 pwa-test-bot[bot]

run cypress

devpatil7 avatar Sep 28 '22 03:09 devpatil7

Successfully started codebuild job for cypress

pwa-test-bot[bot] avatar Sep 28 '22 03:09 pwa-test-bot[bot]

Fails
:no_entry_sign:

node failed.

:no_entry_sign:

Cypress tests in the following files did not pass 😔. All tests must pass before this PR can be merged

  • user should be able to update their address book:
    • CypressError: Timed out retrying after 60000ms: `cy.wait()` timed out waiting `60000ms` for the 1st request to the route: `gqlSignInAfterCreateMutation`. No request ever occurred.

      https://on.cypress.io/wait

Log

ERROR ON TASK: cypressTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by :no_entry_sign: dangerJS against 2ad64f6fd38da5cffdf91494754cbe788fb2eff7

pwa-studio-bot avatar Sep 28 '22 03:09 pwa-studio-bot

run cypress @authuser

devpatil7 avatar Sep 28 '22 13:09 devpatil7

Successfully started codebuild job for cypress with tags @authuser

pwa-test-bot[bot] avatar Sep 28 '22 13:09 pwa-test-bot[bot]

Fails
:no_entry_sign:

node failed.

Log

ERROR ON TASK: cypressTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by :no_entry_sign: dangerJS against 2ad64f6fd38da5cffdf91494754cbe788fb2eff7

pwa-studio-bot avatar Sep 28 '22 13:09 pwa-studio-bot

run lighthouse-desktop

devpatil7 avatar Sep 28 '22 13:09 devpatil7

Successfully started codebuild job for lighthouse-desktop

pwa-test-bot[bot] avatar Sep 28 '22 13:09 pwa-test-bot[bot]

run lighthouse-mobile

devpatil7 avatar Sep 28 '22 13:09 devpatil7

Successfully started codebuild job for lighthouse-mobile

pwa-test-bot[bot] avatar Sep 28 '22 13:09 pwa-test-bot[bot]

Failed cypress not related, the test is passed in previous run. QA Approved.

devpatil7 avatar Sep 28 '22 13:09 devpatil7