pwa-studio icon indicating copy to clipboard operation
pwa-studio copied to clipboard

[bug]: NoProductsFound component not work properly

Open SergioDonati opened this issue 2 years ago • 1 comments

Describe the bug

Component NoProductsFound still use category id instead of uid.

To reproduce

Steps to reproduce the behavior:

  1. Go to in category page
  2. Click on filter without products
  3. NoProductsFound will render with warnings

Expected behavior

No show warnings and validation errors

Possible solutions

NoProductsFound and useNoProductsFound should use uid and expect a string instead of number.

Please let us know what packages this bug is in regards to:

  • [ ] venia-concept
  • [x] venia-ui
  • [ ] pwa-buildpack
  • [x] peregrine
  • [ ] pwa-devdocs
  • [ ] upward-js
  • [ ] upward-spec
  • [ ] create-pwa

SergioDonati avatar Aug 03 '22 13:08 SergioDonati

Hi @SergioDonati. Thank you for your report. To speed up processing of this issue, make sure that you provided sufficient information.

Add a comment to assign the issue: @magento I am working on this


m2-assistant[bot] avatar Aug 03 '22 13:08 m2-assistant[bot]

@adobe export issue to JIRA project PWA as Bug

anthoula avatar Aug 16 '22 18:08 anthoula

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/PWA-2966 is successfully created for this GitHub issue.

github-jira-sync-bot avatar Aug 16 '22 18:08 github-jira-sync-bot