pwa-studio icon indicating copy to clipboard operation
pwa-studio copied to clipboard

[bug]: Link component failing with 12.5 when no prefetch

Open justinconabree opened this issue 2 years ago • 1 comments

Describe the bug

The Link component can prefetch the link's page information. When this prefetch flag is false, it unsets the query that's used. This is failing as of 12.5 (which included an Apollo update).

To reproduce

Steps to reproduce the behavior:

Link component isn't implemented anywhere in base venia. Would need to use the component and not pass in shouldPrefetch

Expected behavior Link component works seemlessly when prefetch flag is false

Possible solutions

There's already checks to not run query when shouldPrefetch is false. Just need to pass in a valid query to useLazyQuery even when the flag is false

Please let us know what packages this bug is in regards to:

  • [ ] venia-concept
  • [ ] venia-ui
  • [ ] pwa-buildpack
  • [x] peregrine
  • [ ] pwa-devdocs
  • [ ] upward-js
  • [ ] upward-spec
  • [ ] create-pwa

justinconabree avatar Jul 15 '22 15:07 justinconabree

Hi @JustinConabreeAbsolunet. Thank you for your report. To speed up processing of this issue, make sure that you provided sufficient information.

Add a comment to assign the issue: @magento I am working on this


m2-assistant[bot] avatar Jul 15 '22 15:07 m2-assistant[bot]

Hello, As I can see this issue got fixed in the scope of the internal Jira ticket PWA-2967 by merging PR. Hence we are closing this.

glo82145 avatar Jun 16 '23 07:06 glo82145