pwa-studio
pwa-studio copied to clipboard
Jconabree/issue 3873 talon exports
…rk correctly
Description
Certain hooks and talons were exporting default instead of a named export. Named exports are required for exposing talons and hooks for wrapping
Note: It would be nice to have a test that checks the export is available so this doesn't occur in the future. Or possibly leverage eslint-import-plugin's no-default-export
rule
Related Issue
Closes #3873
Acceptance
Verification Stakeholders
Specification
Verification Steps
Test scenario(s) for direct fix/feature
Test scenario(s) for any existing impacted features/areas
Is Browser/Device testing needed?
No
Breaking Changes (if any)
Export name changes for affected talons and hooks
Checklist
- [ ] I have added tests to cover my changes, if necessary.
- ~[ ] I have added translations for new strings, if necessary.~
- ~[ ] I have updated the documentation accordingly, if necessary.~
Messages | |
---|---|
:book: | DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed). |
:book: |
Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete. |
Generated by :no_entry_sign: dangerJS against 4e7d9dadd4e0b7ed185c528bcbd518c2a3d7c8cb
run cypress
Successfully started codebuild job for cypress
run lighthouse-desktop
Successfully started codebuild job for lighthouse-desktop
run lighthouse-mobile
Successfully started codebuild job for lighthouse-mobile
QA Approved, would be merged in next major
release.
run cypress
Successfully started codebuild job for cypress
Fails | |
---|---|
:no_entry_sign: |
|
:no_entry_sign: |
Cypress tests in the following files did not pass 😔. All tests must pass before this PR can be merged
|
Log
ERROR ON TASK: cypressTests
Error: Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json
Generated by :no_entry_sign: dangerJS against 4e7d9dadd4e0b7ed185c528bcbd518c2a3d7c8cb
Cypress failures are not related.