pwa-studio icon indicating copy to clipboard operation
pwa-studio copied to clipboard

Jconabree/issue 3873 talon exports

Open justinconabree opened this issue 2 years ago • 8 comments

…rk correctly

Description

Certain hooks and talons were exporting default instead of a named export. Named exports are required for exposing talons and hooks for wrapping

Note: It would be nice to have a test that checks the export is available so this doesn't occur in the future. Or possibly leverage eslint-import-plugin's no-default-export rule

Related Issue

Closes #3873

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Is Browser/Device testing needed?

No

Breaking Changes (if any)

Export name changes for affected talons and hooks

Checklist

  • [ ] I have added tests to cover my changes, if necessary.
  • ~[ ] I have added translations for new strings, if necessary.~
  • ~[ ] I have updated the documentation accordingly, if necessary.~

justinconabree avatar Jun 01 '22 15:06 justinconabree

Messages
:book: DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
:book:

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by :no_entry_sign: dangerJS against 4e7d9dadd4e0b7ed185c528bcbd518c2a3d7c8cb

pwa-studio-bot avatar Jun 01 '22 15:06 pwa-studio-bot

run cypress

dpatil-magento avatar Aug 23 '22 21:08 dpatil-magento

Successfully started codebuild job for cypress

pwa-test-bot[bot] avatar Aug 23 '22 21:08 pwa-test-bot[bot]

run lighthouse-desktop

dpatil-magento avatar Aug 24 '22 04:08 dpatil-magento

Successfully started codebuild job for lighthouse-desktop

pwa-test-bot[bot] avatar Aug 24 '22 04:08 pwa-test-bot[bot]

run lighthouse-mobile

dpatil-magento avatar Aug 24 '22 04:08 dpatil-magento

Successfully started codebuild job for lighthouse-mobile

pwa-test-bot[bot] avatar Aug 24 '22 04:08 pwa-test-bot[bot]

QA Approved, would be merged in next major release.

dpatil-magento avatar Aug 24 '22 16:08 dpatil-magento

run cypress

dpatil-magento avatar Nov 02 '22 18:11 dpatil-magento

Successfully started codebuild job for cypress

pwa-test-bot[bot] avatar Nov 02 '22 18:11 pwa-test-bot[bot]

Fails
:no_entry_sign:

node failed.

:no_entry_sign:

Cypress tests in the following files did not pass 😔. All tests must pass before this PR can be merged

  • user should be able to use radio-boolean filter results in Category and Search pages:
    • AssertionError: Timed out retrying after 30000ms: Expected to find content: '0-100' within the element: [
    • , 4 more... ] and with the selector: '[data-cy="FilterList-item"]' but never did.
  • user should be able to add and remove products from wishlist:
    • CypressError: Timed out retrying after 60000ms: `cy.wait()` timed out waiting `60000ms` for the 1st request to the route: `gqlSignInAfterCreateMutation`. No request ever occurred.

      https://on.cypress.io/wait

  • Validate validations:
    • AssertionError: Timed out retrying after 30000ms: expected '<div.newsletter-root-TID.col-span-6.gap-none.grid.items-start.max-w-[20rem].mx-auto.relative.sm_col-span-3>' to contain text 'Enter a valid email address.', but the text was 'Subscribe to VeniaRecieve the latest news, update and special offers right to your inbox.Unexpected token A in JSON at position 0EmailSubscribeSubscribe'

Log

ERROR ON TASK: cypressTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by :no_entry_sign: dangerJS against 4e7d9dadd4e0b7ed185c528bcbd518c2a3d7c8cb

pwa-studio-bot avatar Nov 02 '22 18:11 pwa-studio-bot

Cypress failures are not related.

dpatil-magento avatar Nov 02 '22 19:11 dpatil-magento