pwa-studio icon indicating copy to clipboard operation
pwa-studio copied to clipboard

[Bugfix] [Refactor] Order confirmation page

Open jcalcaben opened this issue 2 years ago • 6 comments

Description

Fixes a bug with the order confirmation page where data would not persist between a page refresh.

NOTE: This has been fixed for authenticated users, but not for guest users.

This PR also refactors the order confirmation page component to be less coupled with the checkout component.

Related Issue

Closes PWA-2484

Acceptance

Any core developer

Verification Stakeholders

Any core developer

Specification

Verification Steps

  1. Go through checkout as a logged in user
  2. On the order confirmation page, refresh the page
  3. Verify order data is still rendered

Test scenario(s) for direct fix/feature

  1. Verify guest users can still go through checkout steps
  2. Verify authenticated users can go through checkout steps

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Authenticated users logs out and guest user tries to navigate back to the order confirmation page.

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

jcalcaben avatar Mar 04 '22 19:03 jcalcaben

Messages
:book:

Associated JIRA tickets: PWA-2484.

:book: DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
:book:

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by :no_entry_sign: dangerJS against e4e651ddb98f7449a047cc8605dd9d2782186cd7

pwa-studio-bot avatar Mar 04 '22 19:03 pwa-studio-bot

Kind of related so I'll ask - is there any plan to sort the customer orders by most recent date? I believe it's not implemented yet. I'm aware that it's in the scope of the backend, but since work is being done on this page, I got curious. Thanks.

drpayyne avatar Mar 07 '22 17:03 drpayyne

@drpayyne if there isn't a GitHub issue for it already, would you create one for your request about sorting the customer orders?

jcalcaben avatar Mar 09 '22 19:03 jcalcaben

@jcalcaben - found https://github.com/magento/magento2/pull/32435! Hopefully we can get this in one of the next couple Venia releases. :)

drpayyne avatar Mar 10 '22 09:03 drpayyne

run pr-deploy

haal9000 avatar May 25 '22 18:05 haal9000

Successfully started codebuild job for pr-deploy

pwa-test-bot[bot] avatar May 25 '22 18:05 pwa-test-bot[bot]