pwa-studio icon indicating copy to clipboard operation
pwa-studio copied to clipboard

[PWA-2482] Search Results out of Stock

Open mikhaelbois opened this issue 2 years ago • 8 comments

Description

When showing out of stock products in the frontend, we will now show a stock status indicator at the Gallery Item level and in the Product Detail Page.

Related Issue

Closes https://jira.corp.magento.com/browse/PWA-2482.

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

In order to see the out of stock messages, the "Display Out of Stock Products" config should be enabled. The "Only X left Threshold" config should also be above 0.

The following sections should now include the message:

  • Gallery items from Category Pages
  • Gallery items from Search Page
  • Gallery items from Page Builder components
  • Wishlist items
  • Product Detail Page

The Out of Stock message should be shown when:

  • The Simple Product or Configurable Product is Out of Stock

The Low in Stock message should be shown when:

  • The Simple Product stock is below the Only X left Threshold configuration
  • The Configurable Product contains options that are either Out of Stock or has stock below the threshold

Any ad-hoc/edge case scenarios that need to be considered?

Should be tested with "Display Out of Stock Products" config enabled and disabled.

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

mikhaelbois avatar Feb 28 '22 16:02 mikhaelbois

Messages
:book:

Associated JIRA tickets: PWA-2482.

:book: DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
:book:

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by :no_entry_sign: dangerJS against ba4a262475ba062bbd6ede1883a1e36aa6f8c853

pwa-studio-bot avatar Feb 28 '22 17:02 pwa-studio-bot

run all tests

mikhaelbois avatar Feb 28 '22 17:02 mikhaelbois

Successfully started codebuild job for the following test suites:

scaffold-pwa
cypress
pr-test

pwa-test-bot[bot] avatar Feb 28 '22 17:02 pwa-test-bot[bot]

Fails
:no_entry_sign:

node failed.

:no_entry_sign:

Cypress tests in the following files did not pass 😔. All tests must pass before this PR can be merged

  • verify block content:
    • Error: Image was 1.8583289491183264% different from saved snapshot with 119599.0778389369 different pixels. See diff for details: /venia-integration-tests/src/snapshots/integrationTests/pageBuilder/block.spec.js/__diff_output__/Page-Builder-Block-Page.diff.png

Log

ERROR ON TASK: cypressTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by :no_entry_sign: dangerJS against ba4a262475ba062bbd6ede1883a1e36aa6f8c853

pwa-studio-bot avatar Feb 28 '22 17:02 pwa-studio-bot

run cypress

mikhaelbois avatar Feb 28 '22 19:02 mikhaelbois

Successfully started codebuild job for cypress

pwa-test-bot[bot] avatar Feb 28 '22 19:02 pwa-test-bot[bot]

run all tests

mikhaelbois avatar Feb 28 '22 21:02 mikhaelbois

Successfully started codebuild job for the following test suites:

pr-test
scaffold-pwa
cypress

pwa-test-bot[bot] avatar Feb 28 '22 21:02 pwa-test-bot[bot]