pwa-studio icon indicating copy to clipboard operation
pwa-studio copied to clipboard

[Issue] Image not showing

Open m2-assistant[bot] opened this issue 3 years ago • 2 comments

This issue is automatically created based on existing pull request: magento/pwa-studio#3709: Image not showing

Image tag from pagebuilder won't show in frontend. Image tag has "data-set" attribute when getting from pagebuilder, it is "src" attribute written the code file. We are getting wrong attribute, so we had to override this "configAggregator.js" to change ".getAttribute("src")" to ".getAttribute("data-src")" for image tag to show.

Test Plan

  • Create a cms page with page builder content and above mentioned image tag and Verify Storefront cms page image loads fine and also check html content.
  • Verify Cypress snapshot tests pass.
  • Verify Home Page, Customer service, About Us, PDP pagebuilder product attribute images from pagebuilder still loads fine.

Cypress Test coverage

  • Update any one cypress snapshot test mock data to have above mentioned image tag and verify test still pass.

m2-assistant[bot] avatar Feb 28 '22 14:02 m2-assistant[bot]

@magento export issue to JIRA project PWA as Bug

anthoula avatar Feb 28 '22 14:02 anthoula

:white_check_mark: Jira issue https://jira.corp.magento.com/browse/PWA-2645 is successfully created for this GitHub issue.

github-jira-sync-bot avatar Feb 28 '22 14:02 github-jira-sync-bot