pwa-studio icon indicating copy to clipboard operation
pwa-studio copied to clipboard

[bug]: Price filter not showing currency symbol

Open drpayyne opened this issue 4 years ago • 6 comments

Describe the bug

Is there a reason why the price filter doesn't display the currency symbol? This is something I'm happy to contribute if someone gives me a šŸ‘šŸ½. It seems too basic that I feel something is blocking this?

Screenshots

image

Please let us know what packages this bug is in regards to:

  • [ ] venia-concept
  • [x] venia-ui
  • [ ] pwa-buildpack
  • [ ] peregrine
  • [ ] pwa-devdocs
  • [ ] upward-js
  • [ ] upward-spec
  • [ ] create-pwa

drpayyne avatar Nov 20 '21 23:11 drpayyne

Hi @drpayyne. Thank you for your report. To speed up processing of this issue, make sure that you provided sufficient information.

Add a comment to assign the issue: @magento I am working on this


m2-assistant[bot] avatar Nov 20 '21 23:11 m2-assistant[bot]

@magento I am working on this

drpayyne avatar Nov 20 '21 23:11 drpayyne

@magento export issue to JIRA project PWA as Story

anthoula avatar May 16 '22 14:05 anthoula

:white_check_mark: Jira issue https://jira.corp.magento.com/browse/PWA-2841 is successfully created for this GitHub issue.

github-jira-sync-bot avatar May 16 '22 14:05 github-jira-sync-bot

If you have figured this out and would like to contribute your solution back to core, we'd gladly accept it!

anthoula avatar May 16 '22 17:05 anthoula

Hello, yes. I will get around to contributing this back in the next couple of weeks. Thank you!

drpayyne avatar May 18 '22 18:05 drpayyne

@magento I am working on this

denyskuz avatar Oct 03 '22 08:10 denyskuz

@magento I am working on this

Sahilsks avatar Feb 23 '23 02:02 Sahilsks

@magento I am working on this

denyskuz avatar Feb 23 '23 11:02 denyskuz

Issue is reproducible and hence confirming the issue

glo80771 avatar Jul 12 '23 10:07 glo80771

@adobe export issue to JIRA project PWA as Story

glo82145 avatar Jul 13 '23 12:07 glo82145

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/PWA-3170 is successfully created for this GitHub issue.

github-jira-sync-bot avatar Jul 13 '23 12:07 github-jira-sync-bot

This issue is resolved by merging PR https://github.com/magento/pwa-studio/pull/4173.

glo82145 avatar Oct 04 '23 11:10 glo82145