magento2 icon indicating copy to clipboard operation
magento2 copied to clipboard

[Issue] [PHPDOC] Fix bad phpdoc Magento\Eav\Model\ResourceModel\Entity\Attribute\Collection

Open m2-assistant[bot] opened this issue 1 month ago • 2 comments

This issue is automatically created based on existing pull request: magento/magento2#39155: [PHPDOC] Fix bad phpdoc Magento\Eav\Model\ResourceModel\Entity\Attribute\Collection


Description (*)

This PR fix the bad phpdoc for \Magento\Eav\Model\ResourceModel\Entity\Attribute\Collection.

  • joinLeft:
    • The first argument can be string or array<string, array>
    • The 3th argument can be string or array<string>

Here is an example where the type array is used :

https://github.com/magento/magento2/blob/d06337ad4d7a5a783030368a8d49aa70da6a5fca/app/code/Magento/Eav/Model/AttributeRepository.php#L114-L118

For example, with PHPSTAN is very complicated to setup the project with level 5 or higher :(

Capture d’écran du 2024-09-11 09-42-35

Related Pull Requests

None

Fixed Issues (if relevant)

None

Manual testing scenarios (*)

Setup PHPSTAN with level 5 or higher and run check.

Questions or comments

Contribution checklist (*)

  • [ ] Pull request has a meaningful description of its purpose
  • [x] All commits are accompanied by meaningful commit messages
  • [x] All new or changed code is covered with unit/integration tests (if applicable)
  • [x] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • [ ] All automated tests passed successfully (all builds are green)

m2-assistant[bot] avatar Dec 09 '25 11:12 m2-assistant[bot]

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-16187 is successfully created for this GitHub issue.

github-jira-sync-bot avatar Dec 09 '25 11:12 github-jira-sync-bot

:white_check_mark: Confirmed by @engcom-Dash. Thank you for verifying the issue.
Issue Available: @engcom-Dash, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

m2-assistant[bot] avatar Dec 09 '25 11:12 m2-assistant[bot]