[Issue] [PHPDOC] Fix bad phpdoc Magento\Eav\Model\ResourceModel\Entity\Attribute\Collection
This issue is automatically created based on existing pull request: magento/magento2#39155: [PHPDOC] Fix bad phpdoc Magento\Eav\Model\ResourceModel\Entity\Attribute\Collection
Description (*)
This PR fix the bad phpdoc for \Magento\Eav\Model\ResourceModel\Entity\Attribute\Collection.
-
joinLeft:- The first argument can be
stringorarray<string, array> - The 3th argument can be
stringorarray<string>
- The first argument can be
Here is an example where the type array is used :
https://github.com/magento/magento2/blob/d06337ad4d7a5a783030368a8d49aa70da6a5fca/app/code/Magento/Eav/Model/AttributeRepository.php#L114-L118
For example, with PHPSTAN is very complicated to setup the project with level 5 or higher :(
Related Pull Requests
None
Fixed Issues (if relevant)
None
Manual testing scenarios (*)
Setup PHPSTAN with level 5 or higher and run check.
Questions or comments
Contribution checklist (*)
- [ ] Pull request has a meaningful description of its purpose
- [x] All commits are accompanied by meaningful commit messages
- [x] All new or changed code is covered with unit/integration tests (if applicable)
- [x] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
- [ ] All automated tests passed successfully (all builds are green)
:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-16187 is successfully created for this GitHub issue.
:white_check_mark: Confirmed by @engcom-Dash. Thank you for verifying the issue.
Issue Available: @engcom-Dash, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.