magento2 icon indicating copy to clipboard operation
magento2 copied to clipboard
verified publisher icon magento

Fix incorrect grouped product qty returned in GraphQL due to hydration overwriting link attributes

Open mohaelmrabet opened this issue 2 months ago • 5 comments

Description

This pull request fixes an issue where GraphQL returns incorrect or inconsistent qty values for grouped product links.
During GraphQL hydration, the Product::getQty() value is overwritten because it represents a mutable runtime value rather than the original link attribute qty stored in the database.

This causes:

  • GraphQL to return wrong qty values (often 1)
  • REST API to return correct qty values
  • Multiple hydration passes to overwrite values in memory

This PR ensures that GraphQL consistently uses the original link quantity via getInitialQty() (or an equivalent stable fallback), preventing overwriting and ensuring parity between REST and GraphQL.

Related Pull Requests

None.

Fixed Issues

  • Fixes magento/magento2#40286

mohaelmrabet avatar Nov 16 '25 20:11 mohaelmrabet

Hi @mimou78. Thank you for your contribution! Here are some useful tips on how you can test your changes using Magento test environment. :exclamation: Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s) For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here :information_source: Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation. Join Magento Community Engineering Slack and ask your questions in #github channel.

m2-assistant[bot] avatar Nov 16 '25 20:11 m2-assistant[bot]

@magento run Unit Tests

mohaelmrabet avatar Nov 16 '25 20:11 mohaelmrabet

@magento run all tests

mohaelmrabet avatar Nov 17 '25 09:11 mohaelmrabet

@magento run all tests

mohaelmrabet avatar Nov 18 '25 09:11 mohaelmrabet

@magento run Unit Tests

mohaelmrabet avatar Nov 21 '25 23:11 mohaelmrabet