magento2 icon indicating copy to clipboard operation
magento2 copied to clipboard

Change value_id column to be unsigned in db_schema

Open Nolwennig-Jeulin opened this issue 2 months ago • 12 comments

Change value_id column to be unsigned in db_schema.xml to prevent SQLSTATE[22003]: Numeric value out of range: Out of range value for column 'value_id'

SHOW TABLE STATUS LIKE 'catalog_product_entity_varchar' \G
*************************** 1. row ***************************
            Name: catalog_product_entity_varchar
          Engine: InnoDB
         Version: 10
      Row_format: Dynamic
            Rows: 12955092
  Avg_row_length: 64
     Data_length: 840728576
 Max_data_length: 0
    Index_length: 710082560
       Data_free: 6291456
  Auto_increment: 2147485826
     Create_time: 2022-03-06 05:26:46
     Update_time: 2025-11-03 08:43:28
      Check_time: NULL
       Collation: utf8mb3_general_ci
        Checksum: NULL
  Create_options:
         Comment: Catalog Product Varchar Attribute Backend Table
Max_index_length: 0
       Temporary: N
1 row in set (0.002 sec)

Questions or comments

Under what conditions can an auto_increment value be negative?

Contribution checklist (*)

  • [ ] Pull request has a meaningful description of its purpose
  • [ ] All commits are accompanied by meaningful commit messages
  • [ ] All new or changed code is covered with unit/integration tests (if applicable)
  • [ ] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • [ ] All automated tests passed successfully (all builds are green)

Resolved issues:

  1. [x] resolves magento/magento2#40284: Change value_id column to be unsigned in db_schema

Nolwennig-Jeulin avatar Nov 04 '25 11:11 Nolwennig-Jeulin

Hi @Nolwennig-Jeulin. Thank you for your contribution! Here are some useful tips on how you can test your changes using Magento test environment. :exclamation: Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s) For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here :information_source: Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation. Join Magento Community Engineering Slack and ask your questions in #github channel.

m2-assistant[bot] avatar Nov 04 '25 11:11 m2-assistant[bot]

The security team has been informed about this pull request due to the presence of risky security keywords. For security vulnerability reports, please visit Adobe's vulnerability disclosure program on HackerOne or email [email protected].

ct-prd-pr-scan[bot] avatar Nov 04 '25 11:11 ct-prd-pr-scan[bot]

@magento run all tests

Nolwennig-Jeulin avatar Nov 04 '25 11:11 Nolwennig-Jeulin

The security team has been informed about this pull request due to the presence of risky security keywords. For security vulnerability reports, please visit Adobe's vulnerability disclosure program on HackerOne or email [email protected].

ct-prd-pr-scan[bot] avatar Nov 04 '25 11:11 ct-prd-pr-scan[bot]

@adobe/open-source-office Adobe CLA is signed

Nolwennig-Jeulin avatar Nov 04 '25 11:11 Nolwennig-Jeulin

usefull to fix https://github.com/magento/magento2/issues/40269

Nolwennig-Jeulin avatar Nov 04 '25 11:11 Nolwennig-Jeulin

close and re-open to check CLA again

Nolwennig-Jeulin avatar Nov 04 '25 16:11 Nolwennig-Jeulin

The security team has been informed about this pull request due to the presence of risky security keywords. For security vulnerability reports, please visit Adobe's vulnerability disclosure program on HackerOne or email [email protected].

ct-prd-pr-scan[bot] avatar Nov 04 '25 16:11 ct-prd-pr-scan[bot]

The security team has been informed about this pull request due to the presence of risky security keywords. For security vulnerability reports, please visit Adobe's vulnerability disclosure program on HackerOne or email [email protected].

ct-prd-pr-scan[bot] avatar Nov 04 '25 16:11 ct-prd-pr-scan[bot]

The security team has been informed about this pull request due to the presence of risky security keywords. For security vulnerability reports, please visit Adobe's vulnerability disclosure program on HackerOne or email [email protected].

ct-prd-pr-scan[bot] avatar Nov 04 '25 16:11 ct-prd-pr-scan[bot]

@magento create issue

engcom-Hotel avatar Nov 11 '25 11:11 engcom-Hotel

The security team has been informed about this pull request due to the presence of risky security keywords. For security vulnerability reports, please visit Adobe's vulnerability disclosure program on HackerOne or email [email protected].

ct-prd-pr-scan[bot] avatar Nov 11 '25 11:11 ct-prd-pr-scan[bot]