magento2 icon indicating copy to clipboard operation
magento2 copied to clipboard

Added the scp allowlist for Analytics if you only use Google Analytics

Open JeroenBoersma opened this issue 6 months ago • 5 comments

If you disable Google Adwords, the csp_whitelist.xml for that module will not be read.

Description (*)

Having this module for the Analytics module makes this module work in work alone mode without the adwords module enabled.

Manual testing scenarios (*)

  1. Disable the Magento_Adwords module
  2. Enforce CSP (checkout) or manually
  3. The GA code will not be loaded

Contribution checklist (*)

  • [ ] Pull request has a meaningful description of its purpose
  • [ ] All commits are accompanied by meaningful commit messages
  • [ ] All new or changed code is covered with unit/integration tests (if applicable)
  • [ ] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • [ ] All automated tests passed successfully (all builds are green)

Resolved issues:

  1. [x] resolves magento/magento2#40051: Added the scp allowlist for Analytics if you only use Google Analytics

JeroenBoersma avatar Jul 01 '25 14:07 JeroenBoersma

Hi @JeroenBoersma. Thank you for your contribution! Here are some useful tips on how you can test your changes using Magento test environment. :exclamation: Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s) For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here :information_source: Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation. Join Magento Community Engineering Slack and ask your questions in #github channel.

m2-assistant[bot] avatar Jul 01 '25 14:07 m2-assistant[bot]

@magento run all tests

JeroenBoersma avatar Jul 01 '25 17:07 JeroenBoersma

Failed to run the builds. Please try to re-run them later.

@magento run all tests

JeroenBoersma avatar Jul 03 '25 15:07 JeroenBoersma

@magento create issue

engcom-Charlie avatar Jul 08 '25 11:07 engcom-Charlie