magento2
magento2 copied to clipboard
Transliteration of "dashed" characters
Preconditions and environment
- Magento version
- Anything else that would help a developer reproduce the bug
Transliteration of "dashed" characters In the transliteration table few characters are translated with '-' (dash) which is not correct. They have relevant characters from Cyrillic to Latin
https://github.com/magento/magento2/blob/4f82be7a0647afe93b287951bc7605c67e91c546/lib/internal/Magento/Framework/Filter/Translit.php#L268
Ъ -> A
https://github.com/magento/magento2/blob/4f82be7a0647afe93b287951bc7605c67e91c546/lib/internal/Magento/Framework/Filter/Translit.php#L270
Ь -> Y
https://github.com/magento/magento2/blob/4f82be7a0647afe93b287951bc7605c67e91c546/lib/internal/Magento/Framework/Filter/Translit.php#L300
ъ -> а
https://github.com/magento/magento2/blob/4f82be7a0647afe93b287951bc7605c67e91c546/lib/internal/Magento/Framework/Filter/Translit.php#L302
ь -> y
Additionally, keep the character case instead of lowercasing everything. This will allow the Translit Filter to be used in many cases, not just in Translate URLs (where everything is additionally lowercased) https://github.com/magento/magento2/blob/4f82be7a0647afe93b287951bc7605c67e91c546/lib/internal/Magento/Framework/Filter/TranslitUrl.php#L24
Steps to reproduce
Create a product with Name "Дельо Войвода е български хайдутин" Leave URL Key empty and see the generated result
Expected result
delyo-vojvoda-e-balgarski-haydutin
Actual result
del-o-vojvoda-e-b-lgarski-hajdutin
Additional information
No response
Release note
No response
Triage and priority
- [ ] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
- [ ] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
- [ ] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
- [x] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
- [x] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
Hi @Bashev. Thank you for your report. To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.
- For more details, review the Magento Contributor Assistant documentation.
- Add a comment to assign the issue:
@magento I am working on this - To learn more about issue processing workflow, refer to the Code Contributions.
Join Magento Community Engineering Slack and ask your questions in #github channel. :warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting. :clock10: You can find the schedule on the Magento Community Calendar page. :telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.
A very useful bug fix. I hope it helps improve SEO.
Hi @engcom-Bravo. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:
- [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
- [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
- [ ] 3. Add
Area: XXXXXlabel to the ticket, indicating the functional areas it may be related to. - [ ] 4. Verify that the issue is reproducible on
2.4-developbranchDetails
- If the issue is reproducible on2.4-developbranch, please, add the labelReproduced on 2.4.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here! - [ ] 5. Add label
Issue: Confirmedonce verification is complete. - [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.
Hi @Bashev,
Thanks for your reporting and collaboration.
We have tried to reproduce the issue in Latest 2.4-develop instance and we are able to reproduce the issue.Kindly refer the screenshots.
The Product URL was del-o-vojvoda-e-b-lgarski-hajdutin.Hence Confirming the issue.
Thanks.
:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/AC-14970 is successfully created for this GitHub issue.
:white_check_mark: Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.
Finally someone to fix this annoying issue. Thank you!